Code Monkey home page Code Monkey logo

Comments (6)

tdenniston avatar tdenniston commented on May 14, 2024

I figured out the linking issue. It also occurs to me that we could simply reimplement these functions in SkiaSharp instead of calling into the library. Any thoughts on this?

from skiasharp.

bholmes avatar bholmes commented on May 14, 2024

Agree. It feels like these methods should be implemented in C#.

https://github.com/mono/SkiaSharp/blob/master/binding/Binding/Definitions.cs#L72

from skiasharp.

bholmes avatar bholmes commented on May 14, 2024

How about

static public SKColor FromHSV (...)

Can not think of a nice way to get HSV off hand. Could be GetHSV (out h, out s, out v)

from skiasharp.

tdenniston avatar tdenniston commented on May 14, 2024

Could do a subclass approach, SKColorHSV : SKColor with implicit conversion to RGB. That starts to depart from Skia, though, which does not have a separate class.

from skiasharp.

migueldeicaza avatar migueldeicaza commented on May 14, 2024

Add the FromHSV method and GetHSV approaches.

Some code from Mono that implements bits of this:

https://github.com/mono/mono/blob/master/mcs/class/System.Drawing/System.Drawing/Color.cs#L231

from skiasharp.

mattleibow avatar mattleibow commented on May 14, 2024

Added support for to/from both HSV and HSL in 555a626

from skiasharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.