Code Monkey home page Code Monkey logo

Comments (6)

rojer avatar rojer commented on May 26, 2024

i haven't worked with sonoff stuff and i have to admit, i have no idea what you're talking about :)
i vaguely understand that you adapted application for new their API version of the service, right?
if so, i think it's entirely appropriate for example to be converted to new API.

from sonoff-basic-openhab.

scaprile avatar scaprile commented on May 26, 2024

It is a bit more complicated.
Sonoff: the hardware, we discard everything else
openHAB: the Home Automation Bus. The brains.
Homie convention: a way to arrange MQTT topics in order for devices to be autodiscovered and handled with minimum coding.
(binding)API: both 1.x and 2.4+ can be used. The current example works on 1.x with no changes. It works also on 2.4+ with manual addition of the device (thing) and the communication flows (channels), and some changes to the items part of the example.
Some openHAB users still run the 1.x binding and don't care about auto-discovery, they will find the current example as just what they need. The modified version is useless for them.
Other users do enjoy autodiscovery and no manual configuration, they will find the modified version more fit and palatable. They can still use the current example though with some manual intervention and knowledge of the internals, and modifying the code as it is.
Hope the scenario is a bit clearer now, that is why I thought of something like a branch, or a new example linked to the current one.

from sonoff-basic-openhab.

rojer avatar rojer commented on May 26, 2024

ok, so sounds like 1.x api is not on its way out and you say that supporting both in the same app is tricky.
so, maybe create sonoff-basic-openhab2 for that? cross-reference the two from README and that's that. if you like, i can create sonoff-basic-openhab2 and give you admin rights so you can create and maintain it.

from sonoff-basic-openhab.

scaprile avatar scaprile commented on May 26, 2024

Oh, that would be great.

from sonoff-basic-openhab.

rojer avatar rojer commented on May 26, 2024

great. so i created https://github.com/mongoose-os-apps/sonoff-basic-openhab2 and added you as a maintainer. i also added you as a maintainer of this repo.

from sonoff-basic-openhab.

scaprile avatar scaprile commented on May 26, 2024

Thanks!

from sonoff-basic-openhab.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.