Redesign and Improve the Logging Infrastructure about monero HOT 2 OPEN

I don't have a particular affinity for the existing logging infrastructure, but I would just note that changes like this one require a time investment from reviewers and so they need a plausible cost-benefit tradeoff.

The current approach, irrespective of the backing library, has some benefit in its minimalism: Not supporting complex config files means the logging doesn't lock in a particularly set of opinions inherited from a library. If you expose options like file-based config, you're likely stuck with boost, forever, so you make a soft dependency a hard one, effectively increasing the dependency burden. I also don't agree with the characterization that switching from easylogging++ to boost logging eliminates a library dependency, due to the project already using boost: Boost is a collection of many libraries, not one giant library, so every new boost component is a new dependency.

Regardling colorized logging, I don't personally like it, but it exists now, and presumably that means someone thought it worthy of adding. So, removing it requires some buy-in from a variety of parties.

from monero.

all i know is the existing log system is way better than the original one.

I'm also a fan of the colors - it helps spot things while watching the log stream (because... thats what normal people do, right?)

just my 2 cents.

but then again, no one asked me when they changed from the original logging to the current system, and that was a major improvement.

from monero.