Preview SVG image has been broken about typescript-runtime-type-benchmarks HOT 8 CLOSED

@hoeck Wow, you've commented at the same time.

😁

@moltar - If @hoeck founds better way, please discard my PR.

nah, to be honest with you, I don't like having stuff break by updating dependencies.

BUT (huuuuge BUT) it needs to be done. Otherwise it will get harder and harder and finally next to impossible to update anything. So, thanks for pushing this forward 👍.

And in this case, it seems the preview generation is broken because the way I generate the data that is passed to vega-lite. Looks like that only worked because of some undocumented internal behavior in versions before 5.

from typescript-runtime-type-benchmarks.

Components are not sorted by rank (or graph is mis-drawn?).

@samchon right, unfortunately that is a limitation of the "repeated bar graph" of vega-lite that I am (ab)using here.

Vega-lite expects that each single bar graph contains the same libraries - but I want only the fastest 3 so each chart contains a different set. Applying sorting will cause each library to appear in every chart.

An alternative would be to generate a different chart (e.g. a combined bar chart) or to create 4 separate preview SVGs (one for each benchmark) to include in the readme.
Maybe the latter wouldn't look too bad when it's made in the format of a banner.

from typescript-runtime-type-benchmarks.

Hm, that works for me 🤷🏼

What exactly are you seeing? 404? bad code?

from typescript-runtime-type-benchmarks.

Like this

from typescript-runtime-type-benchmarks.

Ah, you are right. I didn't even notice the top-right graph missing. Was so focused on thinking that the file was corrupt.

@hoeck Any ideas?

from typescript-runtime-type-benchmarks.

Seems to be because of a vega-lite major version upgrade: ab324e2#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R76

I'll see if I can find a quick way to get that preview work with the new version.

from typescript-runtime-type-benchmarks.

@hoeck Wow, you've commented at the same time.

@moltar - If @hoeck founds better way, please discard my PR.

from typescript-runtime-type-benchmarks.

@moltar @hoeck Components are not sorted by rank (or graph is mis-drawn?).

from typescript-runtime-type-benchmarks.