Code Monkey home page Code Monkey logo

Comments (4)

dsehnal avatar dsehnal commented on June 11, 2024

Hi, more customization options, including deleting the group when it's empty, could definitely be added. If I understand it correctly, you just want the ability to hide the measurements group completely from the state tree?

As for the ability to select the labels after creation: this could be done either by you manually keeping the refs/selectors, or using the tag option on transforms. I think additional options would need to be added to support the latter as well.

from molstar.

rjdirisio avatar rjdirisio commented on June 11, 2024

If I understand it correctly, you just want the ability to hide the measurements group completely from the state tree?

Yes, that's right. That would make it so we don't have to manage nodes in the state tree by hand

As for the ability to select the labels after creation: this could be done either by you manually keeping the refs/selectors, or using the tag option on transforms. I think additional options would need to be added to support the latter as well.

My issue is that I don't know how to keep track of the refs, since I don't get a ref returned from addLabel, and if I have multiple, similar labels already in my state tree, then it's hard to distinguish any one of them.

from molstar.

rjdirisio avatar rjdirisio commented on June 11, 2024

Ideally, in my case though, we would have the ability to hide Measurements, but not the subsequent Label. That way, when a structure is deleted, the labels get deleted, and there's no leftover nodes in the state tree.

from molstar.

dsehnal avatar dsehnal commented on June 11, 2024

Maybe you can make a PR which adds the ability to create the measurements group as a ghost cell (perhaps via an option in PluginConfig.Structure) and also returns the corresponding refs from the add label/distance/etc. functions? (Just get the .selector from each of the apply calls there).

from molstar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.