Code Monkey home page Code Monkey logo

Comments (3)

Akaame avatar Akaame commented on May 12, 2024

I think this has been already covered by

From this to this and is available from 0.7.0 release on.

from ratelimitj.

sycz avatar sycz commented on May 12, 2024

I have the same problem. 0.7.0 Incompatible with lettuce-core:5.3.7.

es.moki.ratelimitj.redis.request.RedisScriptLoader.loadScript()

java.lang.NoSuchMethodError: io.lettuce.core.api.reactive.RedisScriptingReactiveCommands.scriptLoad(Ljava/lang/String;)Lreactor/core/publisher/Mono;

I compared the two versions(ratelimitj-redis 0.7.0-RC3 / 0.7.0) and found that they were basically the same. Except this:

.retry(1, RedisSlidingWindowRequestRateLimiter::startWithNoScriptError)

.retryWhen(Retry.max(1).filter(RedisSlidingWindowRequestRateLimiter::startWithNoScriptError))

ratelimitj-core doesn't change anything.

But if you run it(ratelimitj-redis:0.7.0) in source code, it works.

I think it(NoSuchMethodError) should not be affected by dependencies.

I wonder what caused it.

from ratelimitj.

xenomachina avatar xenomachina commented on May 12, 2024

The incompatibility with lettuce-core 6.x was fixed in f37eb87, when the dependency on lettuce-core was upgraded from 5.3.4 to 6.0.2, so this issue is resolved as reported.

However, the fix means that users of ratelimitj need to also upgrade lettuce-core 6.x.

@sycz I don't know about now, but back when I reported this issue, the incompatibility wouldn't bite you if you built ratelimitj yourself, because the change that was made to lettuce-core was still source-compatible with ratelimitj, just not binary compatible with anything that used the scriptLoad method from the "wrong" version. Can you upgrade your lettuce-core dependency to 6.x? (The current release is 6.1.8.)

from ratelimitj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.