Open github link on new window about mojs-player HOT 4 CLOSED

@Sandstedt hm, seems like codepen error. Not sure about target="_blank" - from one side it will ensure that user won't loose the context of the current page. From other side - some users can be frustrated since we are deciding for them how to proceed to the next page (they just can hold super key when clicking). What do you think?

from mojs-player.

It has to do with github's server header restrictions (I think). They will not allow loading their site in an iframe. Such small thing, so I think it's better to make it work on CodePen, because all of the examples on the site uses CodePen.

Usually avoid opening in a new window, but in this case I thinks it's the best.

from mojs-player.

makes sense. mind to submit a PR?

from mojs-player.

Pushed the fix, thanks for the issue!

from mojs-player.