The image helper now produces absolute paths about mojo HOT 7 CLOSED

We're effected by this as well, I'll take a crack at a PR.

from mojo.

Yes, this is intentional. The generated URL is supposed to be relative to the static directory of the application.

from mojo.

All right, thank you for the clarification.

This is quite a breaking change for us as we have been treating the parameter as just the verbatim src attribute, doing things like image("https://example.org/test.png"). But we will cope :)

from mojo.

Absolute URLs are actually supposed to be passed through unchanged. If that doesn't work currently it would be incompatible with mojo.js and therefore a bug.

from mojo.

Here's an instance of the behavior in one of our projects:

src="/https://reasonml.github.io/img/reason.svg"

from mojo.

I am getting to work in this.
PD1: Should I change this behavior in sub _file_url?
PD2: I have done a pull request testing the behavior people said was broken. #2149
PD3: I am under the impression that what I tested only duplicates an existing test from #2112 which tests the inner subroutine instead of the helper image. Maybe this issue should be closed?

from mojo.

I will go ahead and close this issue since it was mostly fixed by #2112.

from mojo.