Comments (13)
The GIF is responsive
And all navi functions are working.
I still need to add the About.html file but I can push the any new file to repository
Any way you can set up the pull request, for index.html about html, and styles.css
Need the pull request link show merged for me to get credit for my school assignment
Thank you very much
from codingbooks.
I can do this, you can assign it to me.
from codingbooks.
@Mmollle Go ahead 👍🏻
from codingbooks.
Hello, I can create the about page for you.
I am doing this for school assignment.
The request needs to be merged for me to receive credit for my school assignment.
Can you kindly let me know if this can work, and the issue can be assigned to me?
I can work with other contributor's submission as well.
Thank you very much
from codingbooks.
Yeah, @davidchengl74 you can work on this issue or upgrade it further with @Mmollle 👍
from codingbooks.
Alright and thank you please allow me to look into it.
And will create and send the PR soon.
from codingbooks.
Hi,
I've created the About page, with file About.html.
However, I cannot submit any pull request maybe it is not linked to any file?
The page is highly reused based on AddABook page, and styles.css is added with a new class 'AboutTheProject' where style is same as "LinkDrive" class.
Is there anyway I can merge the pull request for the About.html and styles.css?
I am sure further artistic styling refinements are needed. Output image:
from codingbooks.
Good to go @davidchengl74 but make sure it won't have any errors and it is responsive
from codingbooks.
So, total 3 files were updated.
index.html
about.html
styles.css
I have submitted 3 PRs for those.
Basically Index will have an additional Navi to About
About.html contains all the about information.
styles.css contains the styles used in about page.
All need to be merged in order to work
Please kindly check, as the PR show closed.
from codingbooks.
Hey, I'd like to work on your About us page
Id' like to give you an example of how I'm gonna make the UI
It will be responsive and ill be adding animations in it.
from codingbooks.
@Raeskaa you can go ahead but make sure about the theme color of the project don't create the background of any other color it should match with our project theme color
from codingbooks.
Hi @mohitjaisal
I think the About.html file needs to be merged so the index can reference to it.
And the HTML file is needed for opening the about page.
The file is written mirroring the AddABook page so all functions, theme, color are the same.
Further edits can be done at the file. It is intended as a skeleton page linked with navigation bar from Index and AddABook pages.
from codingbooks.
@Raeskaa you can go ahead but make sure about the theme color of the project don't create the background of any other color it should match with our project theme color
Yeah sure!
Thankyou!
from codingbooks.
Related Issues (18)
- Header Feature HOT 1
- Logo for coding books HOT 6
- Readme enhancement HOT 10
- Javascript filter for books category HOT 3
- Header hover problems HOT 1
- Add responsive download button HOT 7
- Navigation in mobile mode bug HOT 2
- Remove github corner buttons in mobile mode HOT 3
- Download Button Problem HOT 2
- Download Buttons for mobile HOT 5
- add topScroll to logo HOT 2
- give logo text z-index so it can be clickable HOT 1
- which books should add to top books section HOT 1
- Readme Improvements HOT 3
- Enhancement of site's HTML and CSS syntax and structure to Improve SEO attributes and accessibility requirements HOT 3
- About page changes HOT 3
- Adding a Pageup Scroll Button HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codingbooks.