Inconsistent Styling on Typescript Keyword in Dark Theme about vscode.nvim HOT 6 OPEN

@diegodario88 - Hi, This can be done by adding language specific treesitter highlight group. Adding these highlights for all the language is tedious for me. If you add, I will be happy to merge.
Please see https://neovim.io/doc/user/treesitter.html#treesitter-highlight

from vscode.nvim.

@diegodario88 - hl(0, 'typescriptClassKeyword', { fg = c.vscBlue, bg = 'NONE' }) this is non treestiite group, if you are using treestiiter that won't work. The correct solution is hi @variable.builtin.typescript guifg=#569CD6 Put it here under LSP semantic highlight.

from vscode.nvim.

When examining the theme.lua file, I can see that the color for typescriptClassKeyword appears to be correct:

hl(0, 'typescriptClassKeyword', { fg = c.vscBlue, bg = 'NONE' }).

However, in my buffer, the classKeyword is displayed as pink. What steps should I take to resolve this color discrepancy?

Edit: So I found a way to trigger the change by doing for example

:hi @variable.builtin.typescript guifg=#569CD6

that does correct the color for the this keyword in typescript. But I need guidance on where should I put this code

from vscode.nvim.

@Mofiqul - Wouldn't it be better under the -- Treesitter or even the -- Typescript section?
I ask because there's already a entry for this specific group that I want to change see

In my setup configuration I did like this

group_overrides = {
		["@variable.builtin.typescript"] = { fg = vscodeColor.vscBlue, bg = "NONE" },
		["@property.method.typescript"] = { fg = vscodeColor.vscYellow, bg = "NONE" },
		["@constructor.typescript"] = { fg = vscodeColor.vscBlue, bg = "NONE" },
		["@keyword.typescript"] = { fg = vscodeColor.vscBlue, bg = "NONE" },
		["@keyword.return.typescript"] = { fg = vscodeColor.vscPink, bg = "NONE" },
	}

I did that hoping to override only for the typescript group, maybe we should do the same, and if so I think the better place would be under typescript section, right?

from vscode.nvim.

hi, just wondering if this problem will be fixed with any PR?

from vscode.nvim.

hi, just wondering if this problem will be fixed with any PR?

@me-nkr try it now :)

from vscode.nvim.