Problem with recipes about fhist.jl HOT 15 CLOSED

OK, will do (tomorrow)

from fhist.jl.

do you still see this if you run it in REPL? I don't trust Pluto.jl sometimes

from fhist.jl.

Hi, indeed the error does not occur in the REPL. Any idea of what could be wrong with Pluto? Our applications depend heavily of using an interactive notebook (and Pluto offers clear advantages over Jupyter).

from fhist.jl.

you can file an issue in Pluto.jl and see what they say. I suspect it may be have something to do with Requires.jl which we use:

if the Julia you guys use is new enough, you can make a PR to use the new weak deps: SciML/DiffEqBase.jl#856 and I will happily accept the PR

from fhist.jl.

Hi Thanks! I will put an Issue in Pluto. We use a very new version of Julia, but not sure about how to proceed regarding your second comment:

if the Julia you guys use is new enough, you can make a PR to use the new weak deps: https://github.com/SciML/DiffEqBase.jl/pull/856 and I will happily accept the PR

from fhist.jl.

I'm just saying I would welcome a PR to this repo that removes migrate Requires.jl usage to use the now built-in extensions facility of Julia. The link is meant to be an example of what that PR might look like

from fhist.jl.

Hello again, I have tried to follow the examples and submitted at PR with the relevant changes.

from fhist.jl.

is this fixed now after #90 ?

from fhist.jl.

Not fixed yet, I'm afraid. What I did:

1. I rebased my main branch to the main in your branch.
2. Prepare a test repo (https://github.com/jjgomezcadenas/MathTools.jl)
3. Made that test repo dependent of FHist (e.g, my local repo which is sync with your main branch)
4. Run the pluto notebook you can find in the "nb" directory.
5. I get errors when try to use CairoMakie

LoadError: MethodError: no method matching var"@recipe"(::LineNumberNode, ::Module, ::Expr, ::Symbol)

Closest candidates are:

var"@recipe"(::LineNumberNode, ::Module, ::Expr)

@ RecipesBase ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:267

in expression starting at /Users/jjgomezcadenas/.julia/packages/FHist/a1vSI/src/makie.jl:32

in expression starting at /Users/jjgomezcadenas/.julia/packages/FHist/a1vSI/src/makie.jl:32

#macroexpand#[email protected]:119[inlined]
[email protected]:117[inlined]
docm(::LineNumberNode, ::Module, ::Any, ::Any, ::Bool)@Docs.jl:539
docm(::LineNumberNode, ::Module, ::Any, ::Any)@Docs.jl:539
(::DocStringExtensions.var"#35#36"{typeof(DocStringExtensions.template_hook)})(::LineNumberNode, ::Vararg{Any})@templates.jl:11
var"@doc"(::LineNumberNode, ::Module, ::String, ::Vararg{Any})@boot.jl:539
include(::Module, ::String)@Base.jl:457
include(::String)@FHist.jl:1
top-level [email protected]:40
[email protected]:370[inlined]
[email protected]:1[inlined]
(::FHist.var"#106#115")()@require.jl:101
macro [email protected]:393[inlined]
err(::Any, ::Module, ::String, ::String, ::Any)@require.jl:47
(::FHist.var"#105#114")()@require.jl:100
withpath(::Any, ::String)@require.jl:37
(::FHist.var"#104#113")()@require.jl:99
#invokelatest#[email protected]:819[inlined]
[email protected]:816[inlined]
foreach(::typeof(invokelatest), ::Vector{Function})@abstractarray.jl:3075
loadpkg(::Base.PkgId)@require.jl:27
#invokelatest#[email protected]:819[inlined]
[email protected]:816[inlined]
run_package_callbacks(::Base.PkgId)@loading.jl:1129
_tryrequire_from_serialized(::Base.PkgId, ::String, ::String, ::String, ::Vector{Any})@loading.jl:1398
_require_search_from_serialized(::Base.PkgId, ::String, ::UInt128)@loading.jl:1494
_require(::Base.PkgId, ::String)@loading.jl:1783
_require_prelocked(::Base.PkgId, ::String)@loading.jl:1660
macro [email protected]:1648[inlined]
macro [email protected]:267[inlined]
require(::Module, ::Symbol)@loading.jl:1611
top-level scope@[Other: 1](http://localhost:1234/edit?id=06b154a6-8b04-11ee-3efb-e100d2147193#)

So the Makie part doesn't seem to work.

from fhist.jl.

That's not Makie, recipeBase is Plots.jl

from fhist.jl.

It's strange because the nb works for Plots.

from fhist.jl.

Can you make a PR to put Plots.jl Pluto notebook in the doc notebook folder? We should probably include those examples in doc anyway

from fhist.jl.

Yes, the only reason I didn't do it already is that is not clear to me how you call Pluto from the doc folder, not familiar with this structure, can you let me know?

from fhist.jl.

You can make a PR to just add the .jl Pluto file, I will make it work don't worry. It's mostly automated in the build.jl and make.jl file inside the ./docs

from fhist.jl.

Fixed in #92

from fhist.jl.