Change: "nrf24hal" to "nrf24phy" in nrf24-scanner example about modm HOT 11 CLOSED

Yes 👍

from modm.

Can you point me to the line in question in the example code?.

nrf24hal is not a function, but a type if I'm not mistaken.

typedef modm::Nrf24Phy<SpiMaster2, Csn, Ce> nrf24hal;

from modm.

Oh I see, the naming of the type should be nrf24phy. cc @daniel-k

from modm.

All places where it says nrf24hal::xxxxxxx has to be changted to nrf24phy::xxxxxx. My program cannot find nrf24hal, but reading into the code I found out that you must have changed it to nrf24phy.

from modm.

Do you @FadiBunni want to open a Pull Request with that change? It's a good first issue to take you through the process.

from modm.

I never done it before, but would like to know how.

from modm.

I never done it before, but would like to know how.

Possibly the easiest way is to do it online:
https://help.github.com/articles/editing-files-in-another-user-s-repository/

Here is the file in edit mode to get you started.

from modm.

For more complicated changes, you should commit your changes to a separate branch on your fork and manually open the PR:
https://help.github.com/articles/creating-a-pull-request/

from modm.

Alright, I made the simple change for now, but will use the guide for complicated changes, when there is more stuff.

ps: I sent you a mail :)

from modm.

Do you want to open a PR with your changes?
FadiBunni@ec0c030

from modm.

Fixed in #149

from modm.