Code Monkey home page Code Monkey logo

Comments (11)

asfaltboy avatar asfaltboy commented on August 26, 2024

Hi @maingoh thanks for reporting the issue. Which Django version are you using?

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

I edited my comment. I use the version 1.0.7.1.

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 26, 2024

That's the version of advanced-filters. But, what's your Django version?

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

Oh sorry 1.9.13

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

I can probably give you the content of this migration tomorrow if you want?

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 26, 2024

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

It looks like it came from this commit b71d1e9#diff-f2cc63ea5bf7fcd3dbaeb32452043175
The verbose_name needs a new migrations. Here is my generated migration :

# -*- coding: utf-8 -*-
# Generated by Django 1.9.13 on 2018-05-02 14:41
from __future__ import unicode_literals

from django.conf import settings
from django.db import migrations, models
import django.db.models.deletion


class Migration(migrations.Migration):

    dependencies = [
        ('advanced_filters', '0002_advancedfilter_created_at'),
    ]

    operations = [
        migrations.AlterField(
            model_name='advancedfilter',
            name='created_at',
            field=models.DateTimeField(auto_now_add=True, null=True, verbose_name='Created at'),
        ),
        migrations.AlterField(
            model_name='advancedfilter',
            name='created_by',
            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='created_advanced_filters', to=settings.AUTH_USER_MODEL, verbose_name='Created by'),
        ),
        migrations.AlterField(
            model_name='advancedfilter',
            name='groups',
            field=models.ManyToManyField(blank=True, to='auth.Group', verbose_name='Groups'),
        ),
        migrations.AlterField(
            model_name='advancedfilter',
            name='title',
            field=models.CharField(max_length=255, verbose_name='Title'),
        ),
        migrations.AlterField(
            model_name='advancedfilter',
            name='url',
            field=models.CharField(max_length=255, verbose_name='URL'),
        ),
        migrations.AlterField(
            model_name='advancedfilter',
            name='users',
            field=models.ManyToManyField(blank=True, to=settings.AUTH_USER_MODEL, verbose_name='Users'),
        ),
    ]

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

Can I make a PR with this migration ? I would love to see it in a new release 😃

from django-advanced-filters.

maingoh avatar maingoh commented on August 26, 2024

Also it seems it can be squashed directly into the previous migration https://stackoverflow.com/questions/26503826/why-does-django-make-migrations-for-help-text-and-verbose-name-changes

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 26, 2024

Yes, certainly, PRs are more than welcome!

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 26, 2024

Closed in #63

from django-advanced-filters.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.