Code Monkey home page Code Monkey logo

Comments (3)

thomasjpfan avatar thomasjpfan commented on May 14, 2024

This comes from the fact that functions decorated with @pytest.fixture were designed to be passed in as parameters:

@pytest.fixture
def one():
    return 1

def test_simple(one):
    assert one == 1

In the codebase there are fixtures such as:

@pytest.fixture
def test_copy(ray_df):
    ....

def test_mixed_dtype_dataframe():
    ....
    test_copy(ray_df)

One option to refactor this would be:

def assert_copy(ray_df):
    ....

def test_mixed_dtype_dataframe():
    ....
    assert_copy(ray_df)

from modin.

devin-petersohn avatar devin-petersohn commented on May 14, 2024

@thomasjpfan Seems like a reasonable refactor. Once #70 gets merged, this can be done more effectively (and without rebasing issues).

from modin.

devin-petersohn avatar devin-petersohn commented on May 14, 2024

Resolved by #903

from modin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.