Comments (2)
It seems we can't know new_dtypes for columns other than on
in advance. @dchigarev, do you think we should change the logic in _compute_result_metadata
to only compute dtypes for on
or we should completely remove the logic for new_dtypes
computation?
from modin.
It seems we can't know new_dtypes for columns other than on in advance.
I believe in case of a left-merge we can preserve dtypes for 'on' columns and all the columns from the left frame (since the left frame is never reindexed as far as I understand). We can also keep dtypes for the 'object' columns of the right frame, since in this case the column's dtype won't change even if we add NaNs to it.
For an inner merge, it seems that the current logic of dtypes precomputation works just fine (since we don't add NaNs to columns).
from modin.
Related Issues (20)
- Internal function `_validate_dtypes_sum_prod_mean` doesn't process correctly `datetime64[ns]` and `timedelta64[ns]` types
- how to take down ray and put up again in local mode HOT 5
- Left `merge` failed with message: `ValueError: Length mismatch: Expected axis has 36 elements, new values have 32 elements`
- Add type hints for `base.py`
- Support right merge/join
- Update docs as to from_* functions
- Use `extract_dtype` function in more places
- Empty docstrings should not be inherited
- Automatic publication of Modin wheel to PyPI
- Using decorators makes the profile confusing with a lot of circular dependencies.
- Remove `instance_type` attribute of axis partitions
- Remove HDK engine
- Remove deprecated functions from `utils.py`, `accessor.py` and `io.py`
- BUG: AttributeError: 'bool' object has no attribute 'all'
- Remove Cudf storage format as unmaintained
- `enable_logging` decorator does not preserve decorated function type hints
- Using a custom pandas accessor with Modin HOT 1
- Installation of modin using pip fails HOT 4
- Introduce MinRowPartitionSize and MinColumnPartitionSize to make partitioning more flexible
- Remove deprecated configs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modin.