Code Monkey home page Code Monkey logo

Comments (4)

danielozano avatar danielozano commented on August 11, 2024

Hi @coatesjonathan we will add it as optional service when we've some time, if you already have it working please feel free to PR us!

from magento2-dockergento.

ihor-sviziev avatar ihor-sviziev commented on August 11, 2024

Hi @coatesjonathan we will add it as optional service when we've some time, if you already have it working please feel free to PR us!

Hi @danielozano,

Created PRs: ModestCoders/dockerfiles#11 #56

Note: during installing it I got one issue: vm.max_map_count was too low in Ubuntu. Fixed by following instruction https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html#docker-cli-run-prod-mode

This is just 1st version.

Questions that not solved yet:

  1. Should ES be optional?
  2. Should we have some docs for configuring ElasticSearch?
  3. How to add ElasticSearch to existing installations?

from magento2-dockergento.

danielozano avatar danielozano commented on August 11, 2024

Hi @ihor-sviziev, thats true! It's been a long time without updating this issue because of that. For now lets have it included and if someone doesn't want it, just remove it from the setup.

I had a prototype of a "service injector". It was just another command that takes 1 template: the service definition in YAML, and replace some variables. But this variable substitution was hard, and injecting the result into the original docker-compose.yml was overcomplicated.

I would like to have something like that to be as flexible as possible, but maybe it's too much work for non-profit at all.

So let me know it you have some idea, if not maybe just include all the necessary services and start creating some wiki content should be fine!

Thanks again! (I will merge the PRs but im not going to close the issue to keep this conversation)

from magento2-dockergento.

ihor-sviziev avatar ihor-sviziev commented on August 11, 2024

Hi @danielozano,

Adding "service injector" is quite big task and I think we're not going to have too many things. I think following only could be added: Elasticsearch, Varnish, Redis, RabbitMQ.

I think we could update setup CLI that will ask if you would like to include Elasticsearch (default value - no) + writing selected option to config file in order to have an ability re-generate configs again.

Also updating docs - good idea.

Another point - Magento currently developing https://github.com/magento/magento-cloud-docker, but it looks too complicated as for me. Maybe we can re-use their work somehow?

from magento2-dockergento.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.