DllExport in CompatibilityDefs.h about modelica_devicedrivers HOT 5 CLOSED

Do you see what I mean? Check the compiled executable model generated by Dymola and you will notice that it exports those function symbols which is simply not necessary.

The proposed change in CompatibilityDefs.h is simple:

#if defined(MDD_EXPORTS)
# define DllExport __declspec( dllexport ) 
#else
# define DllExport
#endif

You then need to define MDD_EXPORTS only when you build ITI_MDD.dll, ITI_MDDSoftingCAN.dll and MDDSpaceMouse.dll.

For sake of completeness there could also be a MDD_IMPORTS but this is currently not needed since DllImport is referenced nowhere.

from modelica_devicedrivers.

Right, this could be done. But what's the harm if some symbols are exported that are not needed?

from modelica_devicedrivers.

The size of the executable is smaller. I though you would prefer minimum size.

And it is clean programming of course.

from modelica_devicedrivers.

Thanks for that explanation. Minimum size is nice, but I guess the difference isn't so much and keeping things as simple as possible is also a good thing. So I keep it as it is. However, I have no strong opinion about it, so if you have a strong opinion to limit the visibility we'll put that extra logic into the code and the build process.

from modelica_devicedrivers.

I checked it with TestSerialPackager_SoftingCAN.exe where executable size decreased from 458240 Bytes to 453632 Bytes.

Also I have no idea why would an executable export symbols?

I will probably change it in my fork anyway.

from modelica_devicedrivers.