Code Monkey home page Code Monkey logo

Comments (5)

bric3 avatar bric3 commented on May 13, 2024

I still like the after method, can't we just keep it as an alias ?

from mockito.

mockitoguy avatar mockitoguy commented on May 13, 2024

In this case, I'd rather have a single opinionated method (unless I'm convinced otherwise :).

How about this:

mock(foo, after(10).times(2)).bar()
VS
mock(foo, during(10).times(2)).bar()

It feels that 'after' has higher chance of producing ambiguous looking test code.

from mockito.

mockitoguy avatar mockitoguy commented on May 13, 2024

Also, 'after' can be interpreted as:

  1. wait given amount of time
  2. then validate invocations that happen after the time period (e.g. excluding invocations that happened during the time).

AFAIR the implementation does not work this way. The impl expects the invocation(s) 'during' this time :)

from mockito.

bric3 avatar bric3 commented on May 13, 2024

ok I agree, I now remember what this call did. Never mind my original comment.

However, looking at your example, it would feel better if an alias could support TimeUnit.

mock(foo, during(10).times(2)).bar()
mock(foo, during(10, SECONDS).times(2)).bar()

from mockito.

mockitoguy avatar mockitoguy commented on May 13, 2024

Yeah, this kind of alias makes perfect sense.

from mockito.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.