AdditionalMatchers.and() and or() swap matcher order about mockito HOT 5 CLOSED

can i try contribute?

from mockito.

@dev-jonghoonpark feel free to submit a pull request!

from mockito.

I think it's correct that I'm getting an UnnecessaryStubbingException because I didn't enter the expected input. (Passed "hello", not any(MyPojo.class))
However, something feels like the result is not clear.

I think this is normal, I didn’t write the MRE such that the mock would actually be used, but you could simply add a second call with a parameter that matches the mock, e.g.

myService.doSomething(new MyPojo());

from mockito.

Yes this appears to be a legitimate bug, good catch! Feel free to submit a pull request with a fix and a regression test for it!

from mockito.

hello. @TimvdLippe

I found a problem and fixed the code.

I think the problem was that we used stack inside ArgumentMatcherStorageImpl.java, so the order was reversed during the push/pop process.

so I changed code like this (I modified it to assign the result of the popMatcher to m2 first)

public void reportAnd() {
    assertStateFor("And(?)", TWO_SUB_MATCHERS);

    ArgumentMatcher<?> m2 = popMatcher();
    ArgumentMatcher<?> m1 = popMatcher();

    reportMatcher(new And(m1, m2));
}

@Override
public void reportOr() {
    assertStateFor("Or(?)", TWO_SUB_MATCHERS);

    ArgumentMatcher<?> m2 = popMatcher();
    ArgumentMatcher<?> m1 = popMatcher();

    reportMatcher(new Or(m1, m2));
}

Before the fix, m1 and m2 were reversed, as follows

After the fix, m1 and m2 were assigned as expected, as follows

I was happy to think I had fixed the bug.
But sadly, the error changed to the following
(I used the example code provided by the author)

org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
Unnecessary stubbings detected.
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
  1. -> at com.example.demo.MockitoTest.test(MockitoTest.java:22)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
	at org.mockito.junit.jupiter.MockitoExtension.afterEach(MockitoExtension.java:192)
	...

I think it's correct that I'm getting an UnnecessaryStubbingException because I didn't enter the expected input. (Passed "hello", not any(MyPojo.class))
However, something feels like the result is not clear.

What are your thoughts?
I'm wondering if this is a good fix.

If this is the right fix, I'll raise a PR with the addition of test code for this.

(Note that the ./gradlew check passed without fail.)

Have a nice day

from mockito.