Code Monkey home page Code Monkey logo

Comments (4)

mochi-co avatar mochi-co commented on May 16, 2024 1

I think the next step should be adding parameters to server allowing the operator to modify the buffer sizes. I'll try to get a PR done for this in the coming week and we can add it to v1.2.0.

from server.

jmacd avatar jmacd commented on May 16, 2024

(I wonder what happens if a single request exceeds the size of the circular buffer.)

from server.

mochi-co avatar mochi-co commented on May 16, 2024

(I wonder what happens if a single request exceeds the size of the circular buffer.)

The default buffer size is 1024 * 256 (262,144 bytes). There is capacity in EstablishConnection to set this value (currently hardcoded 0 to use default), but it hasn't been opened to allow a custom value as yet.

https://github.com/mochi-co/mqtt/blob/0a7205e1104c323560d66bea8b8a83b38b31c19d/server/server.go#L180-L190

@deadprogram I would be interested to know what happens if you increase the size of the following values:

https://github.com/mochi-co/mqtt/blob/0a7205e1104c323560d66bea8b8a83b38b31c19d/server/internal/circ/buffer.go#L11-L15

If increasing the buffer size allows it to successfully work, we should implement a parameter to adjust this value, and potentially increase the default size.

from server.

deadprogram avatar deadprogram commented on May 16, 2024

Thanks for the quick response. I just tried increasing both of those values, and it did indeed resolve that problem.

From a brief reading of the code seems like server.New() is where the buffer size needs to be able to be changed from the default value.

So what is the best way to proceed from here?

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.