Code Monkey home page Code Monkey logo

Comments (7)

ClarkQAQ avatar ClarkQAQ commented on July 25, 2024 1

I used to be like this too, now the issues should be fixed
see url: b9db59b

from server.

mochi-co avatar mochi-co commented on July 25, 2024

Hi @JackCloudman!

Try connecting to the addressws://localhost:1882 without the /mqtt path. Currently the broker listens for websocket connections on the root path (/). Let me know if this helps.

from server.

JackCloudman avatar JackCloudman commented on July 25, 2024

I got same error :(
image

from server.

mochi-co avatar mochi-co commented on July 25, 2024

@JackCloudman Have you tried connecting using an MQTT client? Does it connect or does it return the same error? Also try connecting to 127.0.0.1 and see what that does.

from server.

JackCloudman avatar JackCloudman commented on July 25, 2024

No, doesn't work, the error is the same, I can't connect to ws://localhost:1882 or ws://127.0.0.1:1882, and I tried changing the port but doest not work.

from server.

mochi-co avatar mochi-co commented on July 25, 2024

That's unusual... Can you confirm the example is running eg. how are you starting the example - what does is the output?

from server.

Surgbc avatar Surgbc commented on July 25, 2024

The clients I am using use mqttv3.1 protocol. So the software does not work at it is with Subprotocols: []string{"mqtt"}, as given in this PR. I have had to modify it to:

wsUpgrader = &websocket.Upgrader{
		Subprotocols: []string{"mqtt", "mqttv3.1"},
		CheckOrigin: func(r *http.Request) bool {
			return true
		},
	}

This hivemq test page and the npm mqtt library both use, for now mqttv3.1

I have noticed that no library that uses which uses [gorilla/websocket] works due to this. I do not know how [golang.org/x/net/websocket] does the handshake, but it works well.

This fix works for me so I do not have to worry if different supported versions for now.

func Subprotocols(r *http.Request) []string {
	h := strings.TrimSpace(r.Header.Get("Sec-Websocket-Protocol"))
	if h == "" {
		return nil
	}
	protocols := strings.Split(h, ",")
	for i := range protocols {
		protocols[i] = strings.TrimSpace(protocols[i])
	}
	return protocols
}

func (l *Websocket) handler(w http.ResponseWriter, r *http.Request) {
	subprotocols := Subprotocols(r)
	wsUpgrader.Subprotocols = subprotocols // very bad assumption is that all the subprotocols will be supported
	c, err := wsUpgrader.Upgrade(w, r, nil)
	if err != nil {
		return
	}
	defer c.Close()
	l.establish(l.id, &wsConn{c.UnderlyingConn(), c}, l.config.Auth)
}

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.