Code Monkey home page Code Monkey logo

Comments (5)

mochi-co avatar mochi-co commented on May 22, 2024 2

@vitalvas Given that Remote and ClientID are both fields of events.Client, I am tempted to pass that directly to both Authenticate and ACL 🤔

The next release will be v1.4.0 and dealing with #101, so I will make this change then 👍🏻

from server.

mochi-co avatar mochi-co commented on May 22, 2024 1

An enhanced auth mechanism will delivered in the new v2.0.0 release that will satisfy this request

from server.

mochi-co avatar mochi-co commented on May 22, 2024 1

This issue has been resolved in v2.0.0 with the addition of universal hooks (particularly OnConnectAuthenticate).

from server.

oliverpool avatar oliverpool commented on May 22, 2024

@mochi-co I discovered your project recently and it looks very neat!

Regarding the Authenticate interface, it could probably be replaced with a function:

// AuthenticateFunc should return ErrAuthBadUsernameOrPassword or ErrAuthNotauthorized
// to reply with a CONNACK and terminate. Any other non-nil error will immediately terminate the connection.
type AuthenticateFunc func(authRequest) (ACL, error)

type ACL interface {
	CanSubscribe(topic string) bool
	CanPublish(topic string) bool
}

var ErrAuthBadUsernameOrPassword = errors.New("bad user name or password")
var ErrAuthNotauthorized = errors.New("not authorized")

Regarding the v2, do you plan to share a branch or some alpha version?

from server.

mochi-co avatar mochi-co commented on May 22, 2024

Thanks @oliverpool! For v2 I am hoping to issue a pre-release in the near (but indeterminate) future. It's a fairly substantial rewrite for stability, performance, and developer flexibility. I am also currently looking at whether it is feasible to implement MQTT 5 as part of this release, but I need to assess the total changes required.

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.