Here are some rough notes I gathered over time.

$ export DOCKERENV=~/docker

$ mkdir -p $DOCKERENV/bin
$ cd $DOCKERENV
$ export GOPATH=$DOCKERENV
$ go get github.com/dotcloud/docker
$ ls -al
total 24
drwxrwxr-x 4 chooper chooper 4096 Mar 12 18:21 .
drwxrwxr-x 50 chooper chooper 12288 Mar 12 18:20 ..
drwxrwxr-x 3 chooper chooper 4096 Mar 12 18:21 bin
drwxrwxr-x 3 chooper chooper 4096 Mar 12 18:21 pkg
drwxrwxr-x 3 chooper chooper 4096 Mar 12 18:21 src
$ cd src/github.com/dotcloud/docker/
$ git checkout master
Switched to branch 'master'
$ git status

On branch master

nothing to commit (working directory clean)

#Show how to add a remote git repo to a fork
$ git remote add FEATURE_BRANCH ssh://[email protected]/USER/docker; git checkout remotes/USER/FEATURE_BRANCH

add the go post commit hook, to clean code (from solomon)

curl -o .git/hooks/pre-commit https://raw.github.com/edsrzf/gofmt-git-hook/master/fmt-check && chmod +x .git/hooks/pre-commit

Build docker

build docker
^^^^^^^^^^^^
$ cd $DOCKERENV/src/github.com/dotcloud/docker/docker
$ go build
$ ls
docker docker.go

from solomon

mkdir /go; export GOPATH=/go; go get github.com/dotcloud/docker; cd ~/go/src/github.com/dotcloud/docker; git remote add pquerna ssh://[email protected]/pquerna/docker; git checkout remotes/pquerna/FEATURE_BRANCH; sudo -E go run ./dockerd; dockerd.go

running tests:
sudo -E /usr/local/go/bin/go test

from moby.

For contribution guidelines we want something like

1. Fork the repo
2. Make changes on your fork in a feature branch
3. Write unit tests for your changes (if needed)
4. Run the full test suite against your change and master
5. update/add any relevant documentation
6. run gofmt to make sure code is formated correctly
7. Add your name to the AUTHORS file
8. submit a pull request explaining what changes you made as clearly as possible, including any issues this pull request might have fixed.

from moby.

I also suggest the following:

• If it's a bugfix branch, name it XXX-something where XXX is the number of the issue
• If it's a feature branch, create an enhancement issue to announce your intentions, and name it the same way
• If a pull request addresses multiple issues, reference them in the pull request (with #XXX)
  (If the issues are already referenced in the individual commits, it's OK to not re-reference them in the pull request message)

from moby.

Volunteer wanted for a pull request incorporating all this

from moby.

@kencochrane I'm walking through the steps outlined and am on $ go get github.com/dotcloud/docker. Should this repo be our own docker repo? If so, trying this yields the following:

$ go get github.com/johncosta/docker
Username for 'https://github.com': johncosta
Password for 'https://[email protected]':
Username for 'https://github.com': johncosta
Password for 'https://[email protected]':
cd .; git clone https://github.com/dotcloud/docker /Users/jcosta/docker/src/github.com/dotcloud/docker
Cloning into '/Users/jcosta/docker/src/github.com/dotcloud/docker'...
error: The requested URL returned error: 403 while accessing https://github.com/dotcloud/docker/info/refs
fatal: HTTP request failed
package github.com/johncosta/docker
imports github.com/dotcloud/docker/auth: exit status 128
package github.com/johncosta/docker
imports github.com/dotcloud/docker/fs
imports github.com/dotcloud/docker/fs
imports github.com/dotcloud/docker/fs: import "github.com/dotcloud/docker/fs": cannot find package
package github.com/johncosta/docker
imports github.com/dotcloud/docker/fs
imports github.com/dotcloud/docker/future
imports github.com/dotcloud/docker/future
imports github.com/dotcloud/docker/future: import "github.com/dotcloud/docker/future": cannot find package
package github.com/johncosta/docker
imports github.com/dotcloud/docker/fs
imports github.com/dotcloud/docker/future
imports github.com/dotcloud/docker/rcli
imports github.com/dotcloud/docker/rcli
imports github.com/dotcloud/docker/rcli: import "github.com/dotcloud/docker/rcli": cannot find package

Could you clarify?

from moby.

@johncosta
no it should be the master repo 'go get github.com/dotcloud/docker'

you should have access to dotcloud/docker after you put your github username and password

from moby.

I think this has been done reasonably well and can be closed.

from moby.