Code Monkey home page Code Monkey logo

Comments (27)

biax avatar biax commented on August 17, 2024

from element-td.

MNoya avatar MNoya commented on August 17, 2024

Releasing a patch full of bug fixes asap should be the priority.

You can include the the stats feature mockup on #477 and I'll take a look at it after we close the critical issues first 😃

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

Visual bugs:

Performance bugs:

  • Building a tower I haven't built before in this patch is crashing the game for me in main client. Haven't checked tools mode yet. Though, once I actually build the tower once, I'm good.

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

Summoning center hotkey appears to have gone borked as well.

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

Why is the map outside of the map box?

I will reduce the height of the player slots to make it fit better on the top bar. We should also put boxes around the bottom right stuff.

All the changes will so need to be tested on 3:4, 16:9, 16:10, 21:9

from element-td.

biax avatar biax commented on August 17, 2024

screenshot_71

heres my input on tidying the UI while you're at it. @WindStrike72 do review

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

Another bug:

  • So I've got 4 lumber, and I've got my builder selected, but because there's no generic "select upgrade" icon, I can't level my elements from here. See here
  • Though, that begs a bit of a question. With the new leveling UI just sticking '+' signs over all the abilities, would it be easier to actually nuke the lumber resource, nuke the elemental summoner, and instead just go with leveling up the hero every 5 waves (3 on express)? So if you started on Express mode, you'd start as Level 2, and if you're on Short mode, you'd start as Level 4. Though I suppose there's no button for random or gaining more essences... I dunno, go with whatever fix is more convenient fer ya Noya.

Regarding UI cleanup no jutsu from biax:

  • Yeah, I'd second removing the elements counter in the bottom-right, it's even more obvious now w/ the new UI. Especially if we wanna fit the new natural UI size in the bottom-right. See here for reference
  • If anything, stick score under the wave box in the top-right, because right under that is where the score bonuses plop up each wave and at the end of the game.
  • Now that there's space, could we move the Settings Icon to the left of the bottom-right area, instead of above? Keep the size as is, it should be fine like that. I've often found myself clicking on it by accident instead of a tower around that area of the screen.
  • I have no frigin' clue where the heck the Tower Table icon should be now, cause I'm pretty sure it's now covering where the new UI backdrop there would be. Not unless we're doin' a custom backdrop, in which case go nuts.

FYI, mah suggestions are intended as mainly a "if it's no real trouble compared to just fixing it".

Also, the screenshot I posted was in 16:9. I'll poke the Karawasanator to check out 21:9 and post a screenshot of how borked it is once fixes are applied. Dunno anyone w/ 4:3 or 16:10 though.

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

You can scale to 21:9 yourself if you set the width and height to the values I have commented in that .lua file.

from element-td.

biax avatar biax commented on August 17, 2024

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

Game of the day happened, though I'm surprised it jumped up that high, given there's multiple bug reports of people not being able to select elements, though I didn't get the issue on my end.

If Noya/Quint/etc. are willing to fix it, let's keep it to the bare minimum and just fix what's broken, not get all the other requested changes. I think there's still some backlog of balance changes that were applied already, so I can get the tooltips with them, don't think it was a whole lot of changes.

from element-td.

Karawasa avatar Karawasa commented on August 17, 2024

@biax Are you able to contribute? Currently, no one is working on updating for 7.00. Any and all help would be appreciated. I agree with @WindStrike72 that we should do the bare minimum.

from element-td.

biax avatar biax commented on August 17, 2024

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

I just got back from being interstate so I can probably get started on some of the fixes. I just need clear reproducible bug reports to do things quickly. I'll tackle the game breaking issues first. Is there a priority list I could follow?

from element-td.

Karawasa avatar Karawasa commented on August 17, 2024

@ynohtna92 That is really great news! I'm not sure about a priority list. @WindStrike72 can you help with that?

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

I'll look into it, starting with the game breaking bugs list. Not sure if I can reproduce them, I recall trying some of them out, and it never crashed on my end. Might've been specific dota versions that were causing it. We'll see. I'll try to get this up in the next day.

from element-td.

biax avatar biax commented on August 17, 2024

i'll list whatever issues i can find, of whatever priority:

in-game interface -- refer to: #479 (comment)

cosmetics issue:
screenshot_89

reproducible crash (tested on my pc only so far, ill wait for some pals to help me test this later): start game -> sandbox -> pause and wait results in dota2 crashing. might need to scroll around a bit im not sure.

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

I'm not running into any crash errors personally anymore, buuut that doesn't mean they're not there.

In terms of visual bugs, I think they're all outlined above and are all still valid. Just do whatever fixes for those that's fastest, no need to do anything fancy.

I just ran a test of all the towers; functionally, they're all still perfectly fine, no visual bugs on them (I think), only thing that was out-of-place was having a pure dark w/ level 3 forge buff and its damage numbers almost going all the way across the portrait, which is hilarious, but hey, at least you can properly see buffed damage numbers now.

For priority list, check out the talent tree crash error and goat's sandbox error, and then after that, look into the visual bugs, which to my knowledge is mainly a bunch of floating UI stuff with missing backdrops.

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

e385f55 Removed 700 UI additions and fixed the left side of the screen.

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

e43998c Fixed top bar button layout.

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

I haven't been able to replicate any crashes or being unable to upgrade elements as the game is played. Can you provide more insight into this mechanic breaking?

from element-td.

biax avatar biax commented on August 17, 2024

from element-td.

Karawasa avatar Karawasa commented on August 17, 2024

I know this is low priority but I would actually like to play this again...so please fix ultra-wide resolution! I can post a screenshot of how it looks to me when I get home.

from element-td.

MNoya avatar MNoya commented on August 17, 2024

you can play in windowed mode for the time being 😅

from element-td.

ynohtna92 avatar ynohtna92 commented on August 17, 2024

bc6c86c Fixes the layout for 21x9

@biax Yes I have tried and it works fine. It could be a dedicated server issue that I cannot reproduce.

I have noticed that onmouseover no longer is working for wave_info.xml. And I have no idea how to fix it.
Our element level up panel also no longer exist.

You should be able to test and push these changes to the master for now so people stop complaining @WindStrike72. I will update the leaderboard tables as well so the correct ones are displaying.

from element-td.

WindStrike72 avatar WindStrike72 commented on August 17, 2024

I'm going ahead and pushing latest changes to public client since it fixes the talent tree crash error and few other UI things, though know I'm intending on running a follow-up patch w/ the actual changelog, tooltips, and remaining fixes you guys are working on. Thanks for taking the time to try and fix el broken doto!

from element-td.

Karawasa avatar Karawasa commented on August 17, 2024

Yes thank you guys!

from element-td.

MNoya avatar MNoya commented on August 17, 2024

Alright if any other problem appears let's make a separate issue, game seems stable now.

from element-td.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.