Code Monkey home page Code Monkey logo

Comments (10)

mnlipp avatar mnlipp commented on September 5, 2024

This is hard for me to reproduce, because I don't have a Windows machine.

I have, nevertheless, checked that the files which are copied here are properly closed. They are. So there is no apparent reason for any lock.

It may be a gradle problem—it opens these files as well. I know about at least one other plugin where a locking issue depends on the gradle version used. From what I have read, gradle 5.0 should be okay and then 5.3, but nothing in between. Which gradle version are you using?

from jdrupes-mdoclet.

bertoso avatar bertoso commented on September 5, 2024

5.2.1

from jdrupes-mdoclet.

mnlipp avatar mnlipp commented on September 5, 2024

Well, then try 5.0 and 5.3 to check if it is a gradle issue.

from jdrupes-mdoclet.

bertoso avatar bertoso commented on September 5, 2024

I was able to build using Ubuntu VM without changing gradle version. Must be an issue with Windows box hmmm.

from jdrupes-mdoclet.

bertoso avatar bertoso commented on September 5, 2024

One more question. How to configure in gradle if I want to use custom highlight.css?

from jdrupes-mdoclet.

mnlipp avatar mnlipp commented on September 5, 2024

Configuring this is currently not supported. Why don't you simply add a doLast (or another task) that overwrites the default files with your versions?

from jdrupes-mdoclet.

nedtwigg avatar nedtwigg commented on September 5, 2024

Confirmed broken (windows only) in gradle 6.4.1 with org.jdrupes.mdoclet version 1.0.9.

from jdrupes-mdoclet.

nedtwigg avatar nedtwigg commented on September 5, 2024

I believe the problem is here:

jdrupes-mdoclet/mdoclet/src/org/jdrupes/mdoclet/MDoclet.java

Lines 285 to 293 in 4161862

try (
InputStream in = MDoclet.class.getResourceAsStream(resource);
OutputStream out = new FileOutputStream(
new File(options.getDestinationDir(), destination))
)
{
Files.copy(in, options.getDestinationDir().toPath().resolve(destination),
StandardCopyOption.REPLACE_EXISTING);
return true;

Line 287 opens an OutputStream, but it isn't used, on line 291 Files.copy is used instead. Windows is less forgiving about filesystem conflicts than unix.

from jdrupes-mdoclet.

mnlipp avatar mnlipp commented on September 5, 2024

Yours to test on Windows (mdoclet 1.0.10)

from jdrupes-mdoclet.

nedtwigg avatar nedtwigg commented on September 5, 2024

Awesome, thanks! Confirmed fixed.

from jdrupes-mdoclet.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.