tickers example is leaking a goroutine about gobyexample HOT 6 CLOSED

I'm aware of this but don't want to complicate these examples to handle these "leak", especially since the programs by design exit very quickly (:

from gobyexample.

I think you meant the "Rate Limiting" example. But, yes, came here to say the same.

go func() {
    for t := range time.Tick(time.Millisecond * 200) {
        burstyLimiter <- t
    }
}()

This is going to hang on channel write when the caller stops reading from burstyLimiter.

from gobyexample.

I hope that the decision to close this can be revisited.

The current code on the site can easily cause a memory leak when used as-is from within a larger program that is a long-running service, say.

The fix is actually not that complicated and is similar to the Tickers example in the documentation.

from gobyexample.

I strongly advise to change this. A lot of people use this example as a coding tip, and producing a goroutine leak is quite serious and very difficult to track.

from gobyexample.

@dbenders This has been superseded by the discussion in #206

from gobyexample.

I just found leaks in our production code leading back to this example (it had been copied by someone who wanted to run code regularly and Google led them here). While the examples are quickly running, this code does spread into real code and sometimes makes its way past code reviews.

from gobyexample.