Deployment failure due to new property subscriptionRequired about apimanagementarmtemplatecreator HOT 13 CLOSED

Hello,

I've fixed this issue in PR #50 . When it is merged it will not be added to the template.

Beste regards

from apimanagementarmtemplatecreator.

Great, thanks!

from apimanagementarmtemplatecreator.

I pull request 52 I fixed the bug by changing the Apiversion to 2018-06-01preview if the property SubscriptionRequired was present.
I guess we need to decide on how to fix the problem.
Maybe introduce a new parameter?

from apimanagementarmtemplatecreator.

I removed my solution because Nils his solution was beter. Hopefully it will be merged soon.

from apimanagementarmtemplatecreator.

from apimanagementarmtemplatecreator.

To solve this issue you only need to merge pull request #52.
@Geronius removed his fix from #50 so it safe to merge it at any time (it will not cause any problems for my fix in #52).

from apimanagementarmtemplatecreator.

This is merged now and should be solved!

from apimanagementarmtemplatecreator.

I am still getting the property but the version is 2017-03-01, do i need to change something when generating the template?

Get-APIManagementTemplate -APIFilters $apiFilters -APIManagement $apiManagementName `
-ResourceGroup $resourceGroupName -SubscriptionId $subscriptionId `
-ExportAuthorizationServers $false -ExportPIManagementInstance $false `
-ExportGroups $false -ExportProducts $false -ParametrizePropertiesOnly $true | Out-File $fileName

{
      "comments": "Generated for resource /subscriptions/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxx/resourceGroups/xxxxx/providers/Microsoft.ApiManagement/service/xxxxxx/apis/xxxxx",
      "type": "Microsoft.ApiManagement/service/apis",
      "name": "[concat(parameters('service_xxxx_name'), '/xxxxx')]",
      "apiVersion": "2017-03-01",
      "properties": {
        "displayName": "XXX XXX",
        "apiRevision": "[parameters('xxx_apiRevision')]",
        "description": "xxx",
        "subscriptionRequired": true,
        "serviceUrl": "[parameters('xxx_serviceUrl')]",
        "path": "xxx",
        "protocols": [
          "https"
        ],
        "authenticationSettings": {
          "oAuth2": null,
          "openid": null
        },
        "subscriptionKeyParameterNames": {
          "header": "Ocp-Apim-Subscription-Key",
          "query": "subscription-key"
        },
        "isCurrent": "[parameters('xxx_isCurrent')]"
      }

from apimanagementarmtemplatecreator.

Sorry, missed to kick of the release...
Here is a new version from PowerShell Gallery
https://www.powershellgallery.com/packages/APIManagementTemplate/1.4.42

from apimanagementarmtemplatecreator.

I actually used a build of the repo, but i tried the gallery now as well and got the same result.

from apimanagementarmtemplatecreator.

Sorry, I did not realize that you were not using Write-APIManagementTemplates.

I made a new pull request #53 were I moved my fix so that it solves this issue for everyone.

from apimanagementarmtemplatecreator.

I should have included that information in the original issue, sorry. Thanks to everyone for the help!

from apimanagementarmtemplatecreator.

Confirmed working, you can close this, thanks!

from apimanagementarmtemplatecreator.