Code Monkey home page Code Monkey logo

Comments (7)

rahulmr avatar rahulmr commented on August 10, 2024

@EugeneSnihovsky Let me check it today.

from gulp-protractor.

rahulmr avatar rahulmr commented on August 10, 2024

@EugeneSnihovsky I checked and it seems it may break depending on many other things like gulp version, selenium version, etc
So I feel will be better to create a separate branch, to do some tests first.

from gulp-protractor.

EugeneSnihovsky avatar EugeneSnihovsky commented on August 10, 2024

@rahulmr Thanks for quick response. Maybe it make sense to move protractor dependency to peerDependency? In this case user will be able to choose protractor version by himself. But it will create breaking changes for your module (none protractor version will be installed automatically)

from gulp-protractor.

rahulmr avatar rahulmr commented on August 10, 2024

@EugeneSnihovsky If you can try including dependency for gulp-protractor as "gulp-protractor": "mllrsohn/gulp-protractor#protractor-v6", in your package.json file and let me know then it will be good.
About peerDependency, it is possible I guess.
The other thought I have is to put 1 async example with latest gulp 4.0.2 and protractor 6.0.0.
I think that might be helpful.

from gulp-protractor.

EugeneSnihovsky avatar EugeneSnihovsky commented on August 10, 2024

@rahulmr I spent some time for testing #protractor-v6 and here is results:

  1. My compilation prepublish scripts fail with same error as in this issue and seems that it still work in progress.
  2. For testing protractor 6.0.0 download selenium-webdriver version that requires Chrome version 76. For now this version is in beta and will be available on July 30

So until July 30 I will use protractor 5x and then check this issue again. Thanks for support and sorry for your lost time :)

from gulp-protractor.

EugeneSnihovsky avatar EugeneSnihovsky commented on August 10, 2024

@rahulmr Hello! Sorry for long time with no response.

I check today protractor 6x again and I think it is still not stable. It has "selenium-webdriver": "^4.0.0-alpha.1" dependency. And for now it in alpha.4 and requires chrome v.77 that is still not released.
So I think we need to wait for selenium-webdriver: 4.x stable version and then try again

from gulp-protractor.

richardstevens avatar richardstevens commented on August 10, 2024

Heya, is there any update on this as there are security issues now for it https://www.npmjs.com/advisories/1500

from gulp-protractor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.