Code Monkey home page Code Monkey logo

Comments (4)

mfn avatar mfn commented on June 14, 2024

I noticed this too; even my own projects based on rebing/graphql-laravel suffer this 😬

I was meant to look into for graphql-laravel but haven't found time yet.

from laravel-graphiql.

spawnia avatar spawnia commented on June 14, 2024

In order to make this happen, I think we would essentially need to switch the configuration from the current format into one that returns configurations for multiple routes.

-return ['route' => ['uri' => '/graphiql', ...], 'endpoint' => '/graphql', ...];
+return [
+    ['route' => ['uri' => '/graphiql/admin', ...]], 'endpoint' => '/graphql/admin', ...],
+    ['route' => [['uri' => '/graphiql/app', ...], 'endpoint' => '/graphql/app', ...],
+];

Then, the routes configuration file would need to iterate over those multiple routes and pass their config to the controller, which in turn passes the configuration values to the view.

I am not looking to implement this change myself. but am open to pull requests.

from laravel-graphiql.

v16Studios avatar v16Studios commented on June 14, 2024

I adapted our fork to support multiple schemas dynamically in the routes.php, this works for us 😄 :

/**
 * Get the schema from the request and append to the configured endpoints.
 */
if ($schema = Str::afterLast(trim(Request::capture()->getPathInfo(), '/'), '/')) {
    $schema = '/' . $schema;
    if ($config->get('graphiql.route.uri') != $schema) {
        $config->set('graphiql.route.uri', $config->get('graphiql.route.uri') . $schema);
        $config->set('graphiql.endpoint', $config->get('graphiql.endpoint') . $schema);
    }
}

from laravel-graphiql.

mfn avatar mfn commented on June 14, 2024

#11 gives a good idea of peoples expectations in this regard. Obviously, this package can't query random other packages config files.

I wonder what we could do here, i.e. have package A (graphql-laravel) provide package B (laravel-graphiql) the information automatically to generate the appropriate routes.

from laravel-graphiql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.