Code Monkey home page Code Monkey logo

Comments (9)

mkuf avatar mkuf commented on July 30, 2024 1

Sure, go ahead 🙂

from prind.

nelsongraca avatar nelsongraca commented on July 30, 2024 1

Done in Klipper3d/klipper#6550

from prind.

mkuf avatar mkuf commented on July 30, 2024

Hey there,
thanks for reaching out.

This seems to be related to upgrading the base images to python 3.12 in #125.
Python 3.12 removed setuptools from the default packages when a venv is created, as described in python/cpython#95299

This should imho be added to the klippy-requirements upstream to achieve compatibility w/ 3.12 and I'll create an PR in the next few days to get this into klipper.

-Markus

from prind.

nelsongraca avatar nelsongraca commented on July 30, 2024

I can spare some time to submit the PR to Klipper if you don't mind.

from prind.

nelsongraca avatar nelsongraca commented on July 30, 2024

New PR on Klipper Klipper3d/klipper#6557

from prind.

nelsongraca avatar nelsongraca commented on July 30, 2024

@mkuf considering how long getting the fix on Klipper is taking, can we add the latest version of python-can as an extra dependency on the container build process and remove when this is fixed upstream?

from prind.

mkuf avatar mkuf commented on July 30, 2024

I don't think its a good idea to upgrade a package that klipper depends on here instead of upstream.

As it was stated in your first PR, a viable workaround is to add setuptools without any version pinning to the venv.
I'll prepare a PR to add this to the klipper image.

from prind.

mkuf avatar mkuf commented on July 30, 2024

PR has been merged.
setuptools will be included with the next images built by the daily github action run.

I'll leave this issue open for now to observe process in your upstream PRs.

from prind.

mkuf avatar mkuf commented on July 30, 2024

In the light of this issue and also #150, I decided that I will revert the klipper base image back to python 3.11, as it does seem that python 3.12 is a bit too bleeding edge for klipper and I favor reliability over up-to-dateness. For now, at least.

-Markus

from prind.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.