Code Monkey home page Code Monkey logo

Comments (6)

mkopylec avatar mkopylec commented on July 26, 2024

Please create a pull request that contains your changes

from charon-spring-boot-starter.

torsten-liermann avatar torsten-liermann commented on July 26, 2024

The pull request: #60
(Over a week ago I wrote to your o2.pl address.)

from charon-spring-boot-starter.

mkopylec avatar mkopylec commented on July 26, 2024

Done, try version 3.0.0

from charon-spring-boot-starter.

torsten-liermann avatar torsten-liermann commented on July 26, 2024

Thanks!

Please note: I do not know anything about gradle.

Running gradlew test, I get the following error:

com.github.mkopylec.charon.specification.TracingSpec > Should capture trace while proxying HTTP request when matching mapping exists and URI is /uri/1/sync FAILED
    com.github.tomakehurst.wiremock.client.VerificationException

com.github.tomakehurst.wiremock.client.VerificationException: A request was unmatched by any stub mapping. Closest stub mapping was:  expected:<
GET
/path/7
> but was:<
GET
/path/7
>
	at com.github.tomakehurst.wiremock.client.VerificationException.forSingleUnmatchedRequest(VerificationException.java:43)
	at com.github.tomakehurst.wiremock.client.VerificationException.forUnmatchedNearMisses(VerificationException.java:48)
	at com.github.tomakehurst.wiremock.junit.WireMockRule.checkForUnmatchedRequests(WireMockRule.java:92)

It is more elegant to import dependency management from spring-boot (org.springframework.boot: spring-boot-dependencies) for dependencies like spring-retry, httpclient, micrometer, commons-lang3.

For future versions of spring-boot, it would be more practical if the spring-boot dependencies are 'optional' or 'provided' (maven jargon) and so do not get into the projects as transitive dependencies.

from charon-spring-boot-starter.

mkopylec avatar mkopylec commented on July 26, 2024

Thanks for advice.
All tests have pass locally on my machine and on travis CI, it's strange why they failed when you run them.

from charon-spring-boot-starter.

torsten-liermann avatar torsten-liermann commented on July 26, 2024

This test works for me on Linux, but not on Windows 10 with the same jdk (1.8.0_171)

from charon-spring-boot-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.