KeyError on multiple nested namespace packages about griffe HOT 6 CLOSED

Hi, thanks for the report, and the test!

What I remember about nested namespace packages, from when I added/fixed support for namespace packages, is that they are a pain to handle correctly 😅

But I understand the use-case of being able to add modules to sub(namespace)-packages (by the way, could you show me your use case? it's always easier to think about a problem with some examples 🙂), so Griffe should definitely support nested namespace packages.

from griffe.

This happens with this library https://github.com/cloudblue/connect-markdown-renderer.

With this change:

diff --git a/src/griffe/mixins.py b/src/griffe/mixins.py
index 6fc0c25..227c716 100644
--- a/src/griffe/mixins.py
+++ b/src/griffe/mixins.py
@@ -85,7 +85,10 @@ class SetMembersMixin(DelMembersMixin):
             else:
                 value.parent = self
         else:
-            self.members[parts[0]][parts[1:]] = value  # type: ignore[attr-defined]
+            try:
+                self.members[parts[0]][parts[1:]] = value  # type: ignore[attr-defined]
+            except KeyError:
+                self.members[parts[0]] = value

it works but I'm not sure this is the right fix.

from griffe.

I've pushed a fix on master, could you try it and tell me if it works?

from griffe.

Many many thanks @pawamoy ! It works like a charm. Do you plan to release a this patch today ?

from griffe.

Great!

Yup, will release now 🙂

from griffe.

Done, v0.24.1 published.

from griffe.