Code Monkey home page Code Monkey logo

Comments (7)

ryuukk avatar ryuukk commented on June 7, 2024 2

Hopefully this gets merged asap and people update their shit, this shit makes everything blurry and painful to read

Please mind your language.

I will not mind my language when people fuck up things and refuse to admit they have fucked up things

from mkdocs.

tomchristie avatar tomchristie commented on June 7, 2024 1

@ryuukk Blocked.

from mkdocs.

ryuukk avatar ryuukk commented on June 7, 2024

I found the cause, i submitted a PR squidfunk/mkdocs-material#6916

Hopefully this gets merged asap and people update their shit, this shit makes everything blurry and painful to read

from mkdocs.

squidfunk avatar squidfunk commented on June 7, 2024

Hopefully this gets merged asap and people update their shit, this shit makes everything blurry and painful to read

Please mind your language.

from mkdocs.

oprypin avatar oprypin commented on June 7, 2024

@ryuukk Thanks for pointing me towards the *-font-smoothing options. I definitely agree with you - if a user has configured their preference for font rendering, what business do individual websites have overriding that preference and standing out like a sore thumb against the entire system?

I am in the opposite camp (grayscale forever!), and I'm guessing probably my browser doesn't support this setting, because I instantly snipe the christmasy-lit-up looking letters when subpixel rendering somehow sneaks into my system, but I've never observed it in Firefox.

And of course for this case, I don't notice if MkDocs themes set it to grayscale because that's what I already have. But I will always support removing any such overrides whenever possible :)

So yes, it is sad that the most used theme for MkDocs - "material" - now considers it a fundamental change to un-mess with the fonts.

As for MkDocs' built-in themes:

  • The "mkdocs" theme never has any mentions of "font-smoothing".

  • The "readthedocs" theme unfortunately inherits some instances of "font-smoothing". But weirdly, of any noticeable things, it is applied only to admonitions from what I observed, and otherwise it's applied only to tiny controls.

    (how do I know? my method of testing was:
    replace -webkit-font-smoothing:antialiased;
    with -webkit-font-smoothing:antialiased;font-family:"Comic Sans MS" !important)

    image

So the original claim from the issue "Mkdocs (any mkdocs theme)" by @stojan97 is either wrong or simply a different claim than @ryuukk 's

Even more weirdly, @stojan97 links to Docusaurus as a "good" opposite example, but their website sets the exact same CSS as mkdocs-material! - -webkit-font-smoothing:antialiased - so this claim makes even less sense then.

But hopefully we can at least agree that MkDocs shouldn't start messing with font rendering in all themes.

from mkdocs.

pawamoy avatar pawamoy commented on June 7, 2024

@ryuukk whether you're right or wrong, that is not a way to speak to anyone. I invite you to read the code of conduct followed by MkDocs. Please try to maintain a respectful and constructive attitude when interacting with other people within the MkDocs community.

from mkdocs.

tomchristie avatar tomchristie commented on June 7, 2024

@stojan97 - Thanks for the report. ☺️
I don't think we'll treat this as an issue unless someone's invested enough to proactively deal with a pull request.

from mkdocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.