Watch changes crash about mjml HOT 6 CLOSED

Hey @laurent-bientz !

This is probably when you save the file with an empty body, I will try to make the error appear without crashing for the next release tomorrow!

Regards,
Guillaume

from mjml.

@GuillaumeBadi : I believe you're correct about it being empty tags. I can confirm that using --watch with the following causes an error:

<mj-body>
  <mj-section>
    <mj-column>
      <mj-text align='left'></mj-text>
    </mj-column>
    <mj-column>
      <mj-text align='right'></mj-text>
    </mj-column>
  </mj-section>
</mj-body>

However, adding text to the mj-text element fixes the problem and an error is not thrown. The error I'm receiving is different though:

Warning: React.renderToStaticMarkup is deprecated. Please use ReactDOMServer.renderToStaticMarkup from require('react-dom/server') instead.
Invariant Violation: renderToStaticMarkup(): You must pass a valid ReactElement.

from mjml.

Hello and thank u for your feedback.

I can't test today but to reproduce the glitch, just put some spaces in your file.

For me, it's crashed and no memories about an empty <mj-body> or <mj-text>.

Btw, i can remember that empty <mj-text> also crashed with basic command line (mjml -r test.mjml --output test.html), so I don't think it's linked to the same pb, maybe i'm wrong.

I'll check next monday

from mjml.

Empty mj-text is now fixed ! Please reopen if you're still having the issue with 1.2.0

from mjml.

Plus the client won't crash anymore and simply log the error message if any 😄

from mjml.

👍

from mjml.