Comments (10)
I sent an email to mailjet product team to ask them to add the logo. Then I'll do the PR.
from mjml.
I think we could add here :
x: {
'share-url': 'https://twitter.com/intent/tweet?url=[[URL]]',
'background-color': '#55acee',
src: `${IMG_BASE_URL}x.png`,
},
And we also need Mailjet to add the x.png file on there server: https://www.mailjet.com/images/theme/v1/icons/ico-social/
from mjml.
I created the PR, we need to wait Mailjet to add the icon : #2776
from mjml.
@ngarnier who is project maintainer now ?
from mjml.
As stated in multiple issues, we won't update the list of default social network just use regular social-element to host your own icon instead.
from mjml.
Maybe you can explain why ? It is easy and one of the main social networks worldwide.
from mjml.
When MJML3 was out custom social element was really painful to write.
MJML4 added mj-social-element
to ease custom social icons, removing the need of maintaining a list of social networks. Multiple times, people ask to add every new or local social network and would require a new version of MJML everytime : that's not something I want to do.
Last time Mailjet simply did remove old logos #2482 #2547 #2551 opening multiple issues, reaching me personally on Slack/Twitter/Mail.
<mj-social-element src="path-to-icon" href="my-profile" />
or <mj-social-element name="x" href="my-profile" />
at least you know that you have to handle hosting your icons instead of relying on something you can't control.
from mjml.
I understand what you say, but then we should remove all native icons from repo to avoid maintenance ?
Otherwise, I don't see how you can refuse maintenance of an existing social network, while all is ready, PR is offered by community member.
from mjml.
@TechnikMax here is the PR you need : #2777
I hope @iRyusa changes his mind, refusing the contribution in this context is a non sense from an Open Source government perspective.
Otherwise, you can simply cherrypick the PR into your project.
from mjml.
Those were kept for MJML3 compatibility (smooth transition with mj-migrate) and should be marked as deprecated you're right. That was a big discussion when moving from MJML 3 to 4 and we should have stated this more clearly.
I'll update the doc to reflect this, and I probably won't merge this.
from mjml.
Related Issues (20)
- Background Color Issue with `mj-button` for color having alpha value HOT 3
- Automatic component dependencies registration when dependency static key is present HOT 1
- mjml is escaping characters HOT 1
- Using custom Google Fonts HOT 2
- mj-container HOT 2
- Squared Images HOT 1
- Set Position HOT 1
- message clipper HOT 8
- Type matcher configuration to accommodate specific use cases HOT 2
- Using <mj-font> does not result in font import in the HTML
- Normal Email Mode - Remove 'max-width: 600' everywhere and replace 'align="center"' with 'align="left"' HOT 1
- Width getting out for the container when using mj-button in mobile preview HOT 1
- Column stacking on mobile only uses 50% width HOT 1
- Setting width in mj-column adds left and right padding HOT 1
- CVE-2022-37620 & switch to htmlnano HOT 9
- Columns are aligning Vertically in desktop mode, when applying border using css class HOT 1
- truncated text on Outlook desktop HOT 3
- MJML Upgrade broke .NET href Url.Page() builder link. HOT 1
- counter-reset CSS inline syntax causes `Cannot set property 'list-1' of undefined` error HOT 1
- MJML not working in Cloudflare Worker HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mjml.