Old logo for X (formally Twitter) about mjml HOT 10 CLOSED

I sent an email to mailjet product team to ask them to add the logo. Then I'll do the PR.

from mjml.

I think we could add here :

  x: {
    'share-url': 'https://twitter.com/intent/tweet?url=[[URL]]',
    'background-color': '#55acee',
    src: `${IMG_BASE_URL}x.png`,
  },

And we also need Mailjet to add the x.png file on there server: https://www.mailjet.com/images/theme/v1/icons/ico-social/

from mjml.

I created the PR, we need to wait Mailjet to add the icon : #2776

from mjml.

@ngarnier who is project maintainer now ?

from mjml.

As stated in multiple issues, we won't update the list of default social network just use regular social-element to host your own icon instead.

from mjml.

Maybe you can explain why ? It is easy and one of the main social networks worldwide.

from mjml.

When MJML3 was out custom social element was really painful to write.
MJML4 added mj-social-element to ease custom social icons, removing the need of maintaining a list of social networks. Multiple times, people ask to add every new or local social network and would require a new version of MJML everytime : that's not something I want to do.

Last time Mailjet simply did remove old logos #2482 #2547 #2551 opening multiple issues, reaching me personally on Slack/Twitter/Mail.

<mj-social-element src="path-to-icon" href="my-profile" /> or <mj-social-element name="x" href="my-profile" /> at least you know that you have to handle hosting your icons instead of relying on something you can't control.

from mjml.

I understand what you say, but then we should remove all native icons from repo to avoid maintenance ?
Otherwise, I don't see how you can refuse maintenance of an existing social network, while all is ready, PR is offered by community member.

from mjml.

@TechnikMax here is the PR you need : #2777
I hope @iRyusa changes his mind, refusing the contribution in this context is a non sense from an Open Source government perspective.

Otherwise, you can simply cherrypick the PR into your project.

from mjml.

Those were kept for MJML3 compatibility (smooth transition with mj-migrate) and should be marked as deprecated you're right. That was a big discussion when moving from MJML 3 to 4 and we should have stated this more clearly.

I'll update the doc to reflect this, and I probably won't merge this.

from mjml.