Code Monkey home page Code Monkey logo

Comments (4)

mjiderhamn avatar mjiderhamn commented on July 30, 2024

Hi Kenny. I don't think we want to go down this path. If we do, why only stop there? What if the ThreadLocal value is a Map that contains objects that has List attributes that contains elements loaded in the web app (and so forth)?

I'm leaning towards, in this case you should primarily fix the source of the leak (clear the ThreadLocal), or write some custom code for the particular leak. I haven't quite decided yet, though.

Do you have any further arguments for making the suggested changes part of the core functionality? Would it benefit if you provided more details of your case? Was it third party library or in house code?

from classloader-leak-prevention.

kmoens avatar kmoens commented on July 30, 2024

Hi,

We experienced the problem with a third-party library, hence why we added it to an extension we did of your library.

If I'm not mistaken the dependency was somewhere deep inside one of the libraries we relied upon. and was quite hard to fix directly. I don't seem to remember exactly which one though since I wrote this code already 6-7 months ago before picking it up again and now submitting it towards you.

I'll attempt to dig up what exactly was the reasoning why we had to make this change.

from classloader-leak-prevention.

mjiderhamn avatar mjiderhamn commented on July 30, 2024

A link to a bug report on the offending third party library would be great!

from classloader-leak-prevention.

kmoens avatar kmoens commented on July 30, 2024

I seem to be unable to find it back, this can be closed.

from classloader-leak-prevention.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.