mjfryc / mjaron-tinyloki-java Goto Github PK

View Code? Open in Web Editor NEW

11.0 11.0 6.0 241 KB

Tiny Grafana Loki client (log sender) written in pure Java 1.8 without any dependencies.

License: MIT License

Java 100.00%

android android-library grafana grafana-loki java java-8 java-android java-se java8 library logger logging logs loki

mjaron-tinyloki-java's People

Contributors

Stargazers

Watchers

Forkers

javaperformance azplanlos tydhot rira12621 ghatasheh lunf

mjaron-tinyloki-java's Issues

Remove "Connection: Close" header

The connection close header is unnecessary and should be removed.

API: Create Labels from other Labels (copy constructor), with delegation in TinyLoki static method.

Thanks for you work.... this library is perfect for our production solution :)

Dereferenced variable may be null

Variable logEncoder may be null here because of this null argument.

Make Prettification optional

Hi, I have added the builder methods withPrettify() and withoutPrettify() to Labels (locally) as my labels value were being corrupted and I couldn't link between Loki and Tempo.

I tested and it would seem that Loki can now (v2.6.1) accept unprettified labels/values.

Do you think this is a good idea?

Paul.

Enable Gzip content encoding by default

There is no reason to skip Gzip content encoding
Skipping encoding make any sense for diagnostic purposes only
It is a functional change - it requires minor version update

Create test coverage badge

Write unit tests

Key of label should be json-string-escaped

mjaron-tinyloki-java/src/main/java/pl/mjaron/tinyloki/JsonLogStream.java

Line 31 in 0b4155f

b.append(entry.getKey());

Add possibility to resend logs on connection failure.

This task is similar to #20.

Implement gzip content encoding

Class Labels overrides equals but not hashCode.

@SuppressWarnings("unused")
public class Labels implements Cloneable {
Class Labels overrides [equals](https://lgtm.com/projects/g/mjfryc/mjaron-tinyloki-java/snapshot/d3f67ecc523b952ef7c612d302fab279b3ed770e/files/src/main/java/pl/mjaron/tinyloki/Labels.java#xd72d4c252d47884:1) but not hashCode.

Separate the worker thread from `LogController`

Worker thread - periodic action of log collecting - should be separated, by:

Extracting interface of any worker thread, e.g. IWorker
Write IWorker implementation with single thread, named WorkerThread
Write WorkerReactiveX implementation which use rx-java instead of separated thread. Add it as different java project [In future, not covered by this issue].
Re-thing about softStop() and hardStop() methods implementation.
Re-thing how to implement it, to give possibility to implement #3.

Implement label length limit

Loki Server may not accept logs due to label length limit.

Grafana Loki server configuration with default label length limits:

https://grafana.com/docs/loki/latest/configuration/

# Maximum length of a label name.
# CLI flag: -validation.max-length-label-name
[max_label_name_length: <int> | default = 1024]

# Maximum length of a label value.
# CLI flag: -validation.max-length-label-value
[max_label_value_length: <int> | default = 2048]