Add support for java.time.LocalDate and java.time.LocalDateTime about parquet4s HOT 7 CLOSED

Hi @moonkev,

I am ver happy that you appreciate my effort! It incites me even more to make this project better and more mature.

I like your idea, especially because one of the goals of this project is to give flexibility to developers to use various data types according to their needs.

I checked your commit. Changes in the TimeValueCodecs look fine! However, I have small doubts about how you handle the TimeZone setting. I didn't think much about the solution when I created #21. Having mutable variable in object of TimeValueCodecs indeed seems as the easiest solution and for sure it is better than what is now. Unfortunately, it still makes impossible for reading different types with different time zone in parallel. And I am not a big fun of global-like mutable variables.
What do you think about having time zone as an optional setting for reader and writer? Writer already has Options parameter. We can add similar one to the reader. Writer and reader can translate it to implicit variable TimeZoneFor[T] and TimeValueCodecs can use it. May sound as over-engineering, still, the whole project is based on type classes so it would be consistent. I am open to your suggestions!

from parquet4s.

I think that definitely makes sense. I have removed the timezone change and squashed down the commit here so now it only contains the change to add the Java 8 date/time API types. If this looks good to you I can create a pull request and we can bring the timezone discussion back into your original ticket #21

from parquet4s.

from parquet4s.

Thank you, I have opened the above reference PR.

EDIT: If you are curious as to the force push on the PR, it is because somehow the additions in the schema resolver got backed out on accident (maybe when I was removing the timezone change), so that was just me adding those back in.

from parquet4s.

Your PR is merged!
I just noticed that CircleCI was disabled for forked PRs. It should work for next ones from now.
Please tell me how soon you want have your changes released. Do you want to handle #21 first? I can have a look at it myself today evening (CET, speaking about time zones...).

from parquet4s.

Thank you. If you are willing to look at #21 that would be great. I wouldn't mind helping on it, but it seems you have a concrete idea on how you would like to implement it (which sounds good by the way). So I'm in no hurry for the release, I can wait for this change as well as #21 as your time permits. Also, I would be glad to help with any testing needed for that item. Thank you again!

from parquet4s.

OK, so I am closing this issue, thanks for contributing! I will ask you for checking #21 when I am ready

from parquet4s.