Code Monkey home page Code Monkey logo

Comments (9)

mjakubowski84 avatar mjakubowski84 commented on July 2, 2024

Hi @flipp5b !
Thank you for the heads up! I would say that you found the bug, and parquet4s-fs2 should not close the file system. Feel free to create a PR with a fix.

from parquet4s.

flipp5b avatar flipp5b commented on July 2, 2024

Hi @mjakubowski84,

Thank you for the great library! Sure, I'll prepare the PR.

from parquet4s.

flipp5b avatar flipp5b commented on July 2, 2024

@mjakubowski84, I'd like to add a test to reproduce the bug, but it looks like the issue is specific to a distributed file system. So I wonder if it's acceptable to add a new test suite with testcontainers running a custom single-node Hadoop cluster image?

from parquet4s.

mjakubowski84 avatar mjakubowski84 commented on July 2, 2024

sure! please do!

from parquet4s.

mjakubowski84 avatar mjakubowski84 commented on July 2, 2024

@flipp5b Thanks for the contribution! Would you like to add a fix also to core & akka so that the bug fix release solves the problem completely?

from parquet4s.

flipp5b avatar flipp5b commented on July 2, 2024

from parquet4s.

mjakubowski84 avatar mjakubowski84 commented on July 2, 2024

Thanks, I appreciate it!

from parquet4s.

mjakubowski84 avatar mjakubowski84 commented on July 2, 2024

@flipp5b Your fixes are released as v2.8.0. Thank you for your contribution!

from parquet4s.

flipp5b avatar flipp5b commented on July 2, 2024

@mjakubowski84, it was a pleasure! Thank you for the instant feedback and the bugfix release!

from parquet4s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.