Code Monkey home page Code Monkey logo

Comments (1)

merlinND avatar merlinND commented on June 13, 2024

For context, I found out about this issue from this generic implementation of the diffuse BSDF in Mitsuba2:

template <typename BSDFSample,
          typename Value = typename BSDFSample::Value,
          typename Spectrum = Spectrum<Value>>
Spectrum eval_impl(const BSDFSample &bs,
                   EMeasure measure,
                   const mask_t<Value> &/*active*/) const {
    // (...)
    Value n_dot_wi = Frame::cos_theta(bs.wi);
    Value n_dot_wo = Frame::cos_theta(bs.wo);

    auto reflectance = select((n_dot_wi <= 0.f) | (n_dot_wo <= 0.f),
                              Spectrum(0.f), Spectrum(m_reflectance));
    // Unexpected result here when Value is Float:
    // select() always returns Spectrum(m_reflectance). 

    return (math::InvPi * n_dot_wo) * reflectance;
}

This type of usage of select in a generic context, along with operator| is very common over the codebase.

from enoki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.