Distorted preview after adjusting for weird screen sizes about tabiancustomcamera HOT 12 CLOSED

from tabiancustomcamera.

I'm pretty sure it's your mPreviewSize variable. For some reason it's being set to that tiny size. Are you sure you copied my copy correctly? To test, write this write this just below the two log outputs that print the preview width and height at the bottom of the file.

mPreviewSize = new Size(1280, 720);
Log.d(TAG, "setUpCameraOutputs: preview width: " + mPreviewSize.getWidth());
Log.d(TAG, "setUpCameraOutputs: preview height: " + mPreviewSize.getHeight());

If that works then we know it's a problem with the mPreviewSize variable.

from tabiancustomcamera.

Wow, writing that line did solve the issue. "mPreviewSize = new Size(1920, 1080)" worked as well.

Would putting the line "mPreviewSize = new Size(1920, 1080);" at this location prevent future issues regarding resolution? Or is there some place else that should be fixed?

from tabiancustomcamera.

Print a log to see what size is selected from this part

if(largest != null){
    mPreviewSize = Utility.chooseOptimalSize(map.getOutputSizes(SurfaceTexture.class),
    rotatedPreviewWidth, rotatedPreviewHeight, maxPreviewWidth,
    maxPreviewHeight, largest);
    // print a log here
}

from tabiancustomcamera.

The size selected here is 256:144. I also checked the screenshots of my log from branch 24 end and branch 25 end and it shows 1920:1080 shrinking to 256:144.. hm..

from tabiancustomcamera.

Then the "ChooseOptimalSize" method is flawed (I doubt that), or one of the inputs to that method are incorrect.
I'll take a look at that later.

from tabiancustomcamera.

Just checked to see if my Utility class is different from your code in branch 2.5, and it looks they are identical. Thanks for helping me out!

from tabiancustomcamera.

This is very strange. I own an s8 and the screen is almost identical.
There isn't much I can do on my end to debug this unfortunately since I don't have an S9.
Replace the "largest != null" if statement with this and show me the log again please.

if(largest != null){
        Log.d(TAG, "setUpCameraOutputs: largest: " + largest.toString());
        mPreviewSize = Utility.chooseOptimalSize(map.getOutputSizes(SurfaceTexture.class),
        rotatedPreviewWidth, rotatedPreviewHeight, maxPreviewWidth,
        maxPreviewHeight, largest);
 }

from tabiancustomcamera.

Hey Mitch, logcat says
largest: 3264x1836
Thanks for your help!

from tabiancustomcamera.

I'm honestly really not sure. It's very strange.
Just to confirm, have you tried cloning the repository fresh, going to branch 2.5, and running it?
If you have, does it still give you the issue?

from tabiancustomcamera.

Hi Mitch, I haven't tried to clone it because I am not familiar with github. But I will try it and check the logs again, get back to you. Thanks!

from tabiancustomcamera.

I'm pretty sure I show you in this video: https://codingwithmitch.com/courses/android-custom-camera/how-use-source-code/

from tabiancustomcamera.