Code Monkey home page Code Monkey logo

Comments (3)

mitchmindtree avatar mitchmindtree commented on July 20, 2024

This sounds very useful and would be a welcome addition!

from daggy.

hellow554 avatar hellow554 commented on July 20, 2024

I started implementing it and quickly noticed that it's harder than I thought. All impls of the Walker trait require a starting node, but I about iterating over every root node, so I'm not quiet sure if I can use the Walker trait at all. I guess I have to create a new one, that doesn't need a NodeId to start with?

Or would you be fine by using the Iterator trait, but that means borrowing of the Dag.

from daggy.

mitchmindtree avatar mitchmindtree commented on July 20, 2024

@hellow554 if there doesn't seem to be a nice solution with the Walker trait I would be content with an Iterator that borrowed the Dag. It would still be very useful even if a user just wanted to collect each of the roots/leaves into a collection before then iterating over them in a way that doesn't borrow the Dag.

If you do have an approach in mind that allows for iterating over roots/leaves without borrowing the Dag but is not suited to a Walker impl, perhaps this could simply be done with an inherent impl? I don't think we need to introduce another trait if this new type is the only one likely to implement it.

Thanks for taking a stab at this btw!

from daggy.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.