Enabling CGO for native builds about gox HOT 9 CLOSED

This seems to have broken builds for different architectures on the same platform...

e.g. https://travis-ci.org/containous/traefik/builds/127956964

from gox.

Done, please let me know if that helps.

from gox.

Isn't that issue addressed here?

from gox.

Sort of. This is the Makefile I'm working with, and you can see that the -cgo flag has been specified for each platform. The problem is that compiling a Linux build on OS X will result in the final binary depending on OS X libs, and thus it fails to execute. If I don't specify -cgo, the built Linux binary works fine but the darwin build fails as it makes use of a C lib.

Given that there's no harm (at least, AFAIK) in allowing the use of C libraries when you're building for the platform that you're running on, -cgo shouldn't be needed and nor should CGO_ENABLED. This seems to be the way Go's own build tool works, and you can see that reflected in this comment:

// cgo must be explicitly enabled for cross compilation builds

from gox.

This makes sense to me. Done.

from gox.

Thanks @mitchellh!

from gox.

I have to agree with @errm. I'm not sure why, but this breaks the linux 386 and ARM builds when running on my linux-based CircleCI build container. No other platforms seem to be affected. I forked the code, rolled back just this change, and used the forked version of gox and it seems to work just fine. 😖

from gox.

Ouch I tested this on my own builds with cgo and it worked but let me add the arch check too!

from gox.

@mitchellh Works for me again now. Thanks for the fix!

from gox.