Code Monkey home page Code Monkey logo

Comments (7)

SegaSnatcher avatar SegaSnatcher commented on July 28, 2024

Good catch! Interesting that some games with this issue have been fixed, but not all.

from gameboy_mister.

maij avatar maij commented on July 28, 2024

I can confirm these audio issues exist on the last 3 releases, earliest being Gameboy_20220429.rbf which was before the recent audio changes. Curious that the latest fixes didn't work for these games. It's probably still an underlying issue with the wav channel (maybe how it's buffering samples?).

from gameboy_mister.

paulb-nl avatar paulb-nl commented on July 28, 2024

These games use the wave channel the same way as the fixed games except for one difference. Snoopy Tennis and Lego Stunt Rally additionally disable and enable all channels by writing $00 and $FF to $FF25 (NR51).

from gameboy_mister.

l33tr avatar l33tr commented on July 28, 2024

These games use the wave channel the same way as the fixed games except for one difference. Snoopy Tennis and Lego Stunt Rally additionally disable and enable all channels by writing $00 and $FF to $FF25 (NR51).

If this is the root cause, is there a way the core can work around this enabling/disabling?

from gameboy_mister.

maij avatar maij commented on July 28, 2024

I have a solution to this, but I'm going to try to include it in a larger set of changes. Just need to work out a few kinks.

from gameboy_mister.

maij avatar maij commented on July 28, 2024

Thanks to Paul for pointing out what the game was actually doing! Made it really easy to pinpoint the problem.

The other stuff I was working on will take more time, but here is a test build that minimises the buzzing sound. Basically when the DACs were enabled/disabled they were being slammed to the maximum voltage. I have set the DAC off output level to be at a 'digital 0' now. There is still some faint buzzing, if you turn the volume up you can hear it. If the real hardware handles these games differently, we'll have to try a slightly different approach.

Gameboy_noise_fix_20230327.zip

from gameboy_mister.

paulb-nl avatar paulb-nl commented on July 28, 2024

I recorded some videos from a Gamecube + Game Boy Player which can be used as a reference to how they sound on a GBA.

I think the core with your fix sounds the same as on these videos so sounds good to me.

Lego Stunt Rally
https://youtu.be/4zLVZ2bPlso

Snoopy Tennis
https://youtu.be/V89-9OBkgW4

from gameboy_mister.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.