Code Monkey home page Code Monkey logo

Comments (4)

davydes avatar davydes commented on May 27, 2024

issue can be fixed in less:

> img, a > img {

from justified-gallery.

miromannino avatar miromannino commented on May 27, 2024

It's not a bad idea to have the link only around the image. In this way the caption can contain links. I need to verify that the lightboxes work well in those cases. Thank you.

from justified-gallery.

lpichoud avatar lpichoud commented on May 27, 2024

Hi,

I also tried this case.
I realized that in this case the margins added to the img are wrong.
If you remove these it fix the issue.

In fact, we need to remove those margins only if img has one or more parents.
In my case, i fixed it adding a class to the item div ...

<div class="image-wall">

<div class="item">
  <a href="#">
    <img src="..." />
  </a>
</div>

<div class="item">
  <img src="..." />
</div>

</div>

And testing it in "displayEntry" function :
var $image = $entry.find('img');
$image.css('width', imgWidth);
$image.css('height', imgHeight);

        if ($image.parent().hasClass('item')) {
            $image.css('margin-left', -imgWidth / 2);
            $image.css('margin-top', -imgHeight / 2);
        }

        $entry.width(imgWidth);
        $entry.height(rowHeight);
        $entry.css('top', y);
        $entry.css('left', x);

In my case, it works for both version : with and without link. I don't know if it works with the others plugin options.
Maybe there is an easier way to count the number of parents and define if margins have to be applied.

Hope this helps,

from justified-gallery.

miromannino avatar miromannino commented on May 27, 2024

Thanks for the help. It will be available in the 3.5. If you want to try this feature before the official release, just use the version in the master branch.

For @lpichoud: I added the 'jg-entry' automatically to each entry to do something similar to your solution.
Thank you for your suggestions.

from justified-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.