MirrorNG meets OpenUPM about mirage HOT 17 CLOSED

fixed, everything appears to be working now.

from mirage.

@favoyang thanks. yes, versioning is on the way. I will use sematic versioning with UPM, it will take some time to set up.

Is there any particular structure needed on the tag? is it just a tag from the upm branch?

you can reach out to me in the mirrorng channel in the mirror discord server

from mirage.

Though the platform can handle any directory structure (package.json position). Tag from the upm branch is recommended.

from mirage.

Done in #24

from mirage.

Does not seem to work:

$ openupm search mirrorng                                                                                                                                         20:48:53
fast search endpoint is not available, using old search.
No matches found for "mirrorng"

from mirage.

I'm checking it now.

from mirage.

Sorry for the issue, it's been fixed manually. I will find the reason behind later then.

from mirage.

The package can be successfully installed via the openupm-cli

$ openupm add com.mirrorng.mirrorng
added: [email protected]
manifest updated, please open unity project to apply changes

But I find a few compile errors for the Examples folder

Library\PackageCache\[email protected]\Examples\Room\Scripts\NetworkRoomManagerExt.cs(6,42): error CS0246: The type or namespace name 'NetworkRoomManager' could not be found (are you missing a using directive or an assembly reference?)

Is this an optional thing? (i.e. to demo the integration with 3rd party library).

A typical solution would be be moving the Samples tot Samples~ folder. The folder with ~ is not get compiled by default. But it make the package development hard. You/me have a few choices

• The openupm build pipeline can solve it magically, by moving the Samples list in the package.json to Samples~ folder (not implemented yet)
• The openupm build pipeline can support a npm prepare / build command, so you can do the some hooks. Notice that openupm build pipeline is running in a linux box.
• There's a tip to use soft link, by actually placing code into the Samples~ folder, but create a symbolic link to Samples and ignore the Samples folder.

Your opinion?

from mirage.

Another question, who publish the 1.3.0 branch? I checked the github workflow and the .releaserc.yml, but it seems only publish the x.y.z-master tag.

from mirage.

@favoyang still fixing the last issue of versioning, first actual release will be 1.0.0
There will be 2 tags per release

• 1.0.0-master is a tag on the master branch
• 1.0.0 is the tag on upm branch.

The examples will be fixed too.

from mirage.

Fixed, version 1.0.0 is out, it is the very first one.

openupm search is still reporting 1.3.0

How often does openupm update it's package list? there will be lots of releases in MirrorNG, every feature, every fix will trigger a release (refactors and documentation do not).

from mirage.

1. I didn't see any tags/releases?

2. openupm, behavior similar to the npm that it can not override/unpublish published versions. (didn't like git, you can delete your tags back and forth). That's why the command line tool returns 1.3.0 the latest successfully built version. But for your case I deleted published content.

   You need run this once in your shell

   rm ~/.openupm/com.openupm.all.json
   

   Now nothing published on openupm

   $ openupm search com.mirrorng.mirrorng
   fast search endpoint is not available, using old search.
   No matches found for "com.mirrorng.mirrorng"
   

   Notice: next time if you messy something in a release, you will have to bump the version to create a new release to fix it.

from mirage.

3. the build pipeline scans every every 5 mins, the build bot run 1 min per release. So package publishing typically in the range of 1~6 mins since your GitHub release, from just been put into the build queue to wait a full cycle.

   You can watch the https://openupm.com/packages/com.mirrorng.mirrorng/ build issues section (need some manually refreshes) to get the build results. In your case all -master suffix tags will fail (as expected) and others shall succeed. The reason they both get processed because 1.0.0-master and 1.0.0 are both valid semver. In future I can add a rule to skip some tags, but that's not our focus this time.

An example of a working package

from mirage.

4. Thanks for fixing the Sample folder.
5. Sorry for letting you go through many issues during the publishing. Usually I deal with repository with existing upm branch and releases, that makes things a lot smooth.

For the timezone reason, I will follow this thread about 8 hours later.

from mirage.

@favoyang
The changes are needed whether I support openupm or not, so you are not making me work any harder.

I am very close to have that 1.0.0 tag fully automated and stable, minor issue still remains. Once 1.0.0 then the dust is settled, I won't be deleting tags anymore, don't worry.

from mirage.

Looks good. added #30 for badges.

from mirage.

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from mirage.