Ability to throw a `Response` object about discuss HOT 7 OPEN

Oh interesting. Hm. I'm guessing you know you can return a Response, but you want this just so you can short-circuit a route handler at any time?

We really need a middleware system in Mirage... this has come up a lot recently and will probably be added in the near term.

from discuss.

but you want this just so you can short-circuit a route handler at any time

exactly, yes

We really need a middleware system in Mirage

yeah, that would be another potential solution for this

from discuss.

I think I'm a little hesitant to merge this in, because it introduces some new "magic" (exceptions in route handlers return a 500, unless they happen to throw Responses), and in general I don't like using exceptions for program logic/control flow.

I think we should eventually introduce middleware pattern to deal with this.

For now, if you wanted to reuse this logic for your route handlers, I think your best bet might be to make a HOF:

this.get('/users', withAuth((schema, request) => {
});

You might also be able to use the application serializer's serialize method to perform some checks / change the response before it goes out. But I agree we need a better story here.

from discuss.

yeah, the withAuth() is pretty much exactly the workaround that I'm using right now. unfortunately though prettier isn't exactly happy about it and transforms it into a multi-line statement... 😅

from discuss.

sucks :/

I'd be happy to prioritize middleware, or even ship it behind a feature flag so we can test it out a bit

from discuss.

You might also be able to use the application serializer's serialize method to perform some checks / change the response before it goes out.

I just tried this out, but it seems like the serializer isn't used at all when I throw something in the route handler. Looking at the code, the this.serialize() call is only done in the successful case, but not for the error case. 🤔

from discuss.

FYI: Transferred this to our Discuss repo, our new home for more open-ended conversations about Mirage!

If things become more concrete + actionable we can create a tracking issue in the main repo.

from discuss.