Comments (5)
@chgl I'm aware of the GPAS__VERSION
setting but assumed it was a bug or preliminary information of how the ttp-fhir-gateway v2 was goint to be implemented.
There is actually quite a bit of confusion concerning these changes as the release notes for gPAS 1.10.2 differ in ReleaseNotes-gPAS-1.10.3-inkl-TTP-FHIR-Gateway-2.0.0.pdf and gpas-1-11-0-ReleaseNotes.pdf.
I was told the changes @makampf and I noticed were made in ttp-fhir-gateway version 2.0.0 but I never managed to succefully test this with the 1.10.2 gPAS docker image from MIRACUM Harbor and a mysql db (which I successfully did with 1.10.3).
However, I was not aware the current implementation is in (production) use with gPAS 1.10.2 which proves those changes were made after 1.10.2. I totally agree we should keep supporting this, as it would not be a bug of the current implementation.
I will add the changes I made to a GPAS__VERSION >= 1.10.3
setting in the pull request.
from fhir-pseudonymizer.
There's a note about different gPAS versions for the GPAS__VERSION
setting at https://github.com/miracum/fhir-pseudonymizer#configuration. If the version is lower than 1.10.2 (https://github.com/miracum/fhir-pseudonymizer/blob/v2.11.0/src/FhirPseudonymizer/GPasFhirClient.cs#L68), then HTTP GET is used and the parameter is called domain
(see https://github.com/miracum/fhir-pseudonymizer/blob/v2.11.0/src/FhirPseudonymizer/GPasFhirClient.cs#L131). If the version is greater or equal to 1.10.2, then HTTP POST is used, the parameter is called target
, and the response object is parsed differently (https://github.com/miracum/fhir-pseudonymizer/blob/v2.11.0/src/FhirPseudonymizer/GPasFhirClient.cs#L150). This is the combination of versions used internally @makampf as far as I am aware. Unfortunately there is no all-in-one container with gpas @1.10.2 and any version of the ttp-fhir-gateway or it would've been useful to include it in the CI for e2e tests.
Now, apparently, there is a third version, where the operation names are turned camelCase (which I find unfortunate) and the result object looks different as well. We should still support the second version described above as it is in production use, but should add a third implementation of GetOriginalValueFor
with the new API described by @jabberwoc. I guess it should be used if GPAS__VERSION >= 1.10.3
(maybe?).
Describing APIs in Markdown is really not great and the industry standard OpenAPI should strongly be encouraged instead, as should API-versioning and explicitely marking breaking changes.
from fhir-pseudonymizer.
To further add to the confusion: The documentation of gPAS 1.10.2 (gpas_anwenderhandbuch_1-10-2.pdf) actually lists the camel case operation names.
Just for the record.
from fhir-pseudonymizer.
Can confirm those changes with ttp-fhir-gateway 2.0.0 and gpas 1.10.2.
Response parameters have changed too. The pseudonym
parameter's value is now of type valueIdentifier
.
E.g.:
{
"name": "pseudonym",
"valueIdentifier": {
"system": "https://ths-greifswald.de/gpas",
"value": "123456"
}
}
from fhir-pseudonymizer.
🎉 This issue has been resolved in version 2.12.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from fhir-pseudonymizer.
Related Issues (11)
- Failed to create CoreCLR, HRESULT: 0x8007000E HOT 7
- Integration Tests for Telemetry
- Include Bundle size as a histogram metric HOT 1
- Dependency Dashboard
- Action Required: Fix Renovate Configuration
- Conditional references
- BUG: Interpreation of URL with missing tailing /
- The automated release is failing 🚨
- Crypto hashing a literal reference uri node HOT 2
- Plans for the next major release (v3) HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fhir-pseudonymizer.