Comments (2)
The specific check that rejects DNS-less DHCP offers is at
Line 245 in 4465412
It seems that Dns.HC is prepared for the possibility of not having a valid DNS server. (
Line 136 in 4465412
I am unsure if/how it should be communicated by DhcpParseOffer that the DHCP request was satisfied, but no DNS was provided.
If you can implement and test the necessary changes, I would gladly merge them.
from shrine.
Sure. I also found that the VirtualBox DHCP server on host networks doesn't send a ROUTER type message (probably because a gateway is not needed considering host networks are local only).
From what I understand a null gateway address will simply cause an invalid address error on addresses outside of the subnet [https://github.com/minexew/Shrine/blob/master/SnailNet/IPv4.HC#L91, https://github.com/minexew/Shrine/blob/master/SnailNet/IPv4.HC#L79], which should work as an error.
As such, the changes to do seem to just be removing the have_dns
and have_router
checks.
EDIT: Actually, it should probably return IPV4_EHOST_UNREACHABLE
. The changes are still trivial, though.
from shrine.
Related Issues (20)
- Revive this please. HOT 11
- Merge network driver improvements from Erythros HOT 2
- How do i solve this issue with snail.py? HOT 3
- Multiple software repositories? HOT 5
- Merge VirtualBox support code from Erythros
- SSE support
- Consider adding text mode / fast-boot
- Clean way to "flush" outgoing packets when closing a socket HOT 1
- Add favicon.ico to Shrine's site HOT 5
- Why is this mostly not in HolyC? HOT 2
- GnuTools/SSH? HOT 4
- Screenfetch won't install on Shrine 5.05 HOT 7
- Files in distro ISO are not compressed
- CI: also produce ready-to-use QEMU/VirtualBox HDD images
- HTTP header parsing must be case-insensitive HOT 1
- Failed to initialize snail HOT 1
- shrine.systems not available HOT 7
- Add support for linux drivers HOT 1
- PCI IRQ Routing HOT 1
- whats a heretic HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shrine.