Comments (3)
If we do change the name, it should be obvious that it's Minetest's specific fork of Irrlicht, i.e. something obvious and clear like "MTIrrlicht".
from irrlicht.
I think from the README it's sufficiently clear that this is not Irrlicht but our fork.
Or do you suggest changing some of the internal naming too (so that the file is called e.g. libMtIrrlicht.so.1.9.0
)?
from irrlicht.
It is just better to give this baby a real and more or less unique name, otherwise you will have to refer to it in an awkward way like “our Irrlicht fork” or even worse, just “Irrlicht” (when it's actually not the real Irrlicht). IMHO there's no real excuse for maintaining this completely avoidable confusion.
But I don't think a rename needs to go all-in with literally renaming all the internal stuff as well, that would be overkill and will probably make backporting attempts very painful.
I think the rename can be just as simple as changing the repo name and how it's called in the README and maybe other highly visible files, while keeping most internal stuff like function names unchanged to avoid overkill.
On the other hand, when I think about it … libMtIrrlicht.so.1.9.0
might actually be a good idea. Otherwise, how else would the system distinguish this fork from the real Irrlicht. This also begs the question, what should the user do if they want to install Minetest's Irrlicht fork along the real Irrlicht, when both are named exactly the same? Deliberately keeping the Irrlicht name unchanged for this fork seems like asking for trouble. ;-)
from irrlicht.
Related Issues (20)
- Solaris? HOT 1
- MinGW dependencies HOT 2
- SDL 2: Numpad keys don't work HOT 1
- SDL 2 on Windows: Problems with Unicode/UTF-8
- SDL 2 on Windows: Minetest doesn't respect global display scaling setting HOT 1
- SDL 2 on Windows: Can't take screenshots in fullscreen mode HOT 6
- SDL2 Wayland: Random, imprecise scrolling HOT 1
- SDL2: Can not switch IME to English state by pressing shift key HOT 4
- Cannot build newest commit on arch linux HOT 8
- TGA image loader has buffer overflows HOT 20
- Windows/SDL CI builds fail
- Cleanup line endings
- Windows+SDL broken by #225
- Vulkan rendering backend HOT 13
- GetStringi failure won't get handled HOT 4
- Invalid comparator: vector3df/vector2df operator< HOT 3
- ISceneNode::removeChild() is slow HOT 5
- Crash on startup with "old" OpenGL driver on Linux HOT 2
- Failed to runtest on arm64 and arm64ec on MSVC on windows HOT 1
- Add support for multi-sample textures HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irrlicht.