Code Monkey home page Code Monkey logo

Comments (3)

v-rob avatar v-rob commented on June 15, 2024 2

If we do change the name, it should be obvious that it's Minetest's specific fork of Irrlicht, i.e. something obvious and clear like "MTIrrlicht".

from irrlicht.

sfan5 avatar sfan5 commented on June 15, 2024 1

I think from the README it's sufficiently clear that this is not Irrlicht but our fork.
Or do you suggest changing some of the internal naming too (so that the file is called e.g. libMtIrrlicht.so.1.9.0)?

from irrlicht.

Wuzzy2 avatar Wuzzy2 commented on June 15, 2024

It is just better to give this baby a real and more or less unique name, otherwise you will have to refer to it in an awkward way like “our Irrlicht fork” or even worse, just “Irrlicht” (when it's actually not the real Irrlicht). IMHO there's no real excuse for maintaining this completely avoidable confusion.

But I don't think a rename needs to go all-in with literally renaming all the internal stuff as well, that would be overkill and will probably make backporting attempts very painful.

I think the rename can be just as simple as changing the repo name and how it's called in the README and maybe other highly visible files, while keeping most internal stuff like function names unchanged to avoid overkill.

On the other hand, when I think about it … libMtIrrlicht.so.1.9.0 might actually be a good idea. Otherwise, how else would the system distinguish this fork from the real Irrlicht. This also begs the question, what should the user do if they want to install Minetest's Irrlicht fork along the real Irrlicht, when both are named exactly the same? Deliberately keeping the Irrlicht name unchanged for this fork seems like asking for trouble. ;-)

from irrlicht.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.